This is an archive of the discontinued LLVM Phabricator instance.

[clangd] Send suppported codeActionKinds to the client.
ClosedPublic

Authored by hokein on Aug 22 2019, 7:25 AM.

Details

Summary

This would make client know which codeActionKinds that clangd may
return.

VSCode will add a new entry "Refactor..." (which shows all
refactoring-kind code actions) in the right-click menu.

Diff Detail

Repository
rL LLVM

Event Timeline

hokein created this revision.Aug 22 2019, 7:25 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 22 2019, 7:25 AM
ilya-biryukov accepted this revision.Aug 22 2019, 7:38 AM

LGTM

clang-tools-extra/clangd/ClangdLSPServer.cpp
467 ↗(On Diff #216616)

NIT: a typo, s/codeActionProvide/codeActionProvider

468 ↗(On Diff #216616)

s/action liveral/action literal

469 ↗(On Diff #216616)

NIT: remove 'support', remove parentheses?

Otherwise we have clients supports action literal support

This revision is now accepted and ready to land.Aug 22 2019, 7:38 AM
hokein updated this revision to Diff 216625.Aug 22 2019, 7:51 AM
hokein marked 3 inline comments as done.

Fix the comment.

This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptAug 22 2019, 7:53 AM