Page MenuHomePhabricator

[Sanitizer] checks ASLR on FreeBSD
ClosedPublic

Authored by devnexen on Aug 22 2019, 4:54 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

devnexen created this revision.Aug 22 2019, 4:54 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptAug 22 2019, 4:54 AM
Herald added subscribers: llvm-commits, Restricted Project, krytarowski. · View Herald Transcript
dim accepted this revision.Aug 22 2019, 10:48 AM

LGTM. Maybe nice to merge it to 9.0 after a day or two.

compiler-rt/lib/sanitizer_common/sanitizer_linux.cpp
2027 ↗(On Diff #216586)

Note that the aslr.pie_enable sysctl is specifically for PIE executables, so maybe mention that? (This is just a nit.)

This revision is now accepted and ready to land.Aug 22 2019, 10:48 AM
This revision was automatically updated to reflect the committed changes.