This is an archive of the discontinued LLVM Phabricator instance.

[TableGen] Correct comments for end of namespace. NFC
ClosedPublic

Authored by bjope on Aug 18 2019, 12:06 PM.

Details

Summary

Update end-of-namespace comments generated by
tablegen emitters to fulfill the rules setup by
clang-tidy's llvm-namespace-comment checker.

Fixed a few end-of-namespace comments in the
tablegen source code as well.

Event Timeline

bjope created this revision.Aug 18 2019, 12:06 PM

Basically I assume that nobody really cares about formatting and comments in generated code (so in one sense this is stupd, and in another sense it won't hurt much either).

The benefit is that if I run clang-tidy on the llvm/lib/Target code like this

../clang-tools-extra/clang-tidy/tool/run-clang-tidy.py -clang-tidy-binary build/bin/clang-tidy -p build -header-filter=.* lib/Target/

then I will get less complaints related to the tablegen-generated code.

Haven't added any reviewers (and I don't really know who would be appropriate, @stoklund is "code owner" for tablegen but haven't been active for over two years afaict).
Maybe this is something that even can be pushed without review? Or could some people be afraid of "unneccessary" diffs introduced by this patch, so I need to gather more opinions/feedback about this?

craig.topper accepted this revision.Aug 20 2019, 12:23 PM
craig.topper added a subscriber: craig.topper.

LGTM

This revision is now accepted and ready to land.Aug 20 2019, 12:23 PM
This revision was automatically updated to reflect the committed changes.