This is an archive of the discontinued LLVM Phabricator instance.

[lld][WebAssembly] Honor --no-export-dynamic even with -shared
ClosedPublic

Authored by sbc100 on Aug 16 2019, 12:07 PM.

Event Timeline

sbc100 created this revision.Aug 16 2019, 12:07 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 16 2019, 12:07 PM
sbc100 updated this revision to Diff 215653.Aug 16 2019, 12:08 PM
  • add test
Harbormaster completed remote builds in B36894: Diff 215653.
ruiu accepted this revision.Aug 18 2019, 11:59 PM

LGTM

lld/test/wasm/shared-export-dynamic.ll
19–20 ↗(On Diff #215653)

nit: delete trailing blank lines

lld/wasm/Driver.cpp
362

Maybe removing this temporary variable and directly using config->shared is little simpler?

This revision is now accepted and ready to land.Aug 18 2019, 11:59 PM
sbc100 updated this revision to Diff 215930.Aug 19 2019, 9:28 AM
  • feedback
This revision was automatically updated to reflect the committed changes.

This is a nice change! Unfortunately GNU linkers don't suppress symbols in -shared --no-export-dynamic mode...