Page MenuHomePhabricator

[AsmPrinter] Remove const qualifier from EmitBasicBlockStart.
ClosedPublic

Authored by ebevhan on Aug 16 2019, 5:09 AM.

Details

Summary

Overriders may want to modify state in it. AMDGPU wants
to, but has to make its members mutable in order to do so.

Besides, EmitBasicBlockEnd is not const, so why should
Start be?

Diff Detail

Repository
rL LLVM

Event Timeline

ebevhan created this revision.Aug 16 2019, 5:09 AM
ebevhan edited the summary of this revision. (Show Details)Aug 16 2019, 5:12 AM
nickdesaulniers accepted this revision.Fri, Aug 16, 1:01 PM

Bonus points for *removing* the use of mutable.

This revision is now accepted and ready to land.Fri, Aug 16, 1:01 PM
Ka-Ka added a subscriber: Ka-Ka.Mon, Aug 19, 7:13 AM
This revision was automatically updated to reflect the committed changes.