- User Since
- Dec 17 2015, 1:48 AM (191 w, 3 d)
Jun 3 2019
May 29 2019
What about a testcase? It shouldn't be hard to add a small testcase that demonstrate that the changed builtins now work when compiling OpenCL C code for x86. I don't think you have to add all changed builtins to the testcase (but a few to demonstrate the change).
May 16 2019
May 15 2019
Updated according to review comments
May 14 2019
Added a new C++ testcase.
Removed the REQUIRES: avr-registered-target in the avr-builtins.c testcase.
May 12 2019
Feb 18 2019
Feb 15 2019
Feb 14 2019
Jan 3 2019
Dec 18 2018
Do you think this small lit testcase below work as a testcase for the -ffile-macro-prefix-to-remove option?
Dec 7 2018
Jul 30 2018
I found another reproducer for the problem. This one is slightly different where a different assert blow, but I guess its only a different symptom for the same fault. As this one is slightly smaller you might want to use this one as a testcase instead (or use both)? Run with "opt -bounds-checking -S".
Jul 23 2018
Jun 20 2018
Fixed another case when PHI nodes are not correctly updated.
This time it is when switch is replaced with a single branch.
Jun 12 2018
The fix solves the problem I saw originally in a out of tree target (described in PR37745) but I don't know JumpThreading enough to say if the fix is good or not. Thanks for working on this.
Jun 4 2018
Jun 1 2018
Updated testcases according to comments
May 30 2018
Updated testcase according to comment.
May 26 2018
May 25 2018
Added Jonas Devlieghere as reviewer as he was involved in the review of rL327851 (which seems to be the reason for this patch).
Reduced the size of the testcase.
Adding Matthew Simpson and Sanjay Patel as reviewers also as they have done work in ConstantFold recently.
May 23 2018
The reason for me to use WeakTrackingVH instead of WeakVH from the beginning was only that it was used elsewhere in the file. However as you point out WeakVH should be fine as RAUW is not used in RecursivelyDeleteTriviallyDeadInstructions(). I adjust the code to use WeakVH.
May 22 2018
May 21 2018
May 18 2018
May 14 2018
Anyone up for reviewing this?
This definitely solve the problem I saw in the issue pr37369.
May 9 2018
Changed testcase according what was suggested by lebedev.ri
Anyone up for reviewing this?
May 7 2018
May 2 2018
Apr 26 2018
Adding Matthias Braun and Krzysztof Parzyszek as reviewer as it seems you both have done work in BranchFolding.cpp before. Do you have time to review this change?
Apr 25 2018
Feb 7 2018
As I said before the change LGTM, but I would prefer if someone else also reviewed this change.
Feb 1 2018
The change LGTM, but I'm not sure if I'm allowed to set "ready to land". I would prefer if Adrian Prantl or Reid Kleckner also reviewed this change (both now added as reviewers).
Nov 9 2017
Oct 4 2017
Sep 29 2017
Sep 27 2017
When I tried your test program above I found that faulty hoisting of a DBG_VALUE across the call to usevals seems to be done by the CodeGenPrepare pass (before instruction selection). This must be a bug. If you want I can convert code above into a testcase but it will contain this faulty hoisted DBG_VALUE from the CodeGenPrepare pass. This patch will not impact that testcase.
Sep 26 2017
Sep 25 2017
Sep 18 2017
Sep 5 2017
I updated the testcase according to what David Blaikie suggested.
I also rewrote to code to be a bit more robust and avoid emitting unnecessary stoppoints.
Sep 3 2017
Mar 24 2017
Feb 14 2017
I had to revert this change due to a buildbot failure. I'm trying to recreate the fault locally ...
Feb 13 2017
Updated the testcase "run line"
Feb 9 2017
Updated the testcase to use FileCheck.
Feb 8 2017
Any news about this issue?
Dec 29 2016
Dec 20 2016
I have a reproducer for an out of target backend. I will give it a try (tomorrow) to transform it into a x86 reproducer, but I suspect that it might be hard to get it working.
Sep 23 2016
This patch solve the problem I have in the "out of tree" backend I work with. Many thanks!
Jun 15 2016
The testcase was originally only reduced with creduce but now also with bugpoint.
Jun 8 2016
Anyone interested in reviewing this bugfix?
May 31 2016
Inverted diff. Abandon.