Page MenuHomePhabricator

[DebugInfo] Allow bundled calls in the MIR's call site info

Authored by dstenb on Aug 13 2019, 8:43 AM.



Extend the MIR parser and writer so that the call site information can
refer to calls that are bundled.

Diff Detail


Event Timeline

dstenb created this revision.Aug 13 2019, 8:43 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 13 2019, 8:43 AM
arsenm added a subscriber: arsenm.Aug 13 2019, 9:01 AM
arsenm added inline comments.
1 ↗(On Diff #214846)

MIR parser tests usually go to test/CodeGen/MIR. Should just -run-pass=none -verify-machineinstrs

Thanks a lot for this! It looks reasonable to me.
(I am not sure if I can approve it, so please wait for @aprantl and @vsk too)

dstenb updated this revision to Diff 215041.Aug 14 2019, 1:30 AM

Update test case according to comments.

dstenb marked an inline comment as done.Aug 14 2019, 1:31 AM
aprantl accepted this revision.Aug 14 2019, 8:55 AM

I don't know enough about VLIW bundle handling to really decide, but mechanically, this seems good.

This revision is now accepted and ready to land.Aug 14 2019, 8:55 AM

Thanks for the reviews! I can let this sit in Phabricator for a few more days to see if there are any more comments before landing it.

This revision was automatically updated to reflect the committed changes.