Details
Diff Detail
Event Timeline
LGTM - conditional to the parent patch.
lib/CodeGen/GlobalISel/LegalizerHelper.cpp | ||
---|---|---|
3774 | Would it be possible to buildInstr in a way that it can be CSE'd (collect the regs in a SmallVector and build in the end)? |
lib/CodeGen/GlobalISel/LegalizerHelper.cpp | ||
---|---|---|
3774 | It's possible, but I find the intermediate vectors for these sorts of things kind of annoying to use and it seemed more straightforward to add operands directly |
lib/CodeGen/GlobalISel/LegalizerHelper.cpp | ||
---|---|---|
3774 | Even if it's annoying, I'd prefer we try to build instructions in a way that's CSEable and in parallel maybe look at ways to make this less annoying. |
Would it be possible to buildInstr in a way that it can be CSE'd (collect the regs in a SmallVector and build in the end)?
While I think the chances of CSEing a G_BUILD_VECTOR is quite low, it probably doesn't hurt to enable it.