This is an archive of the discontinued LLVM Phabricator instance.

Differential D65874

[lldb][CMake] Disable modules in Xcode projects
ClosedPublic

Authored by sgraenitz on Aug 7 2019, 7:46 AM.

Details

Reviewers
aprantl
jingham
davide
teemperor
Commits
rGc822ab8f9acc: [lldb][CMake] Disable modules in Xcode projects
rL368294: [lldb][CMake] Disable modules in Xcode projects
rLLDB368294: [lldb][CMake] Disable modules in Xcode projects
Summary

Apparently, module-enabled builds clash with Xcode's analysis.

Diff Detail

Repository
rL LLVM

Event Timeline

sgraenitz created this revision.Aug 7 2019, 7:46 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 7 2019, 7:46 AM
Herald added a subscriber: mgorny. · View Herald Transcript
Harbormaster completed remote builds in B36330: Diff 213882.Aug 7 2019, 7:46 AM
davide accepted this revision.Aug 7 2019, 9:17 AM

You might want to check with Argyrios, maybe file a rdar against SourceKit.
Otherwise, this is fine to me.

This revision is now accepted and ready to land.Aug 7 2019, 9:17 AM
teemperor added a comment.Aug 8 2019, 2:58 AM

Do we have a radar tracking the SourceKit issue? This *should* work and I'm curious if this is actually SourceKit or if this is just a broken LLVM+modules build.

Closed by commit rL368294: [lldb][CMake] Disable modules in Xcode projects (authored by stefan.graenitz). · Explain WhyAug 8 2019, 6:39 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptAug 8 2019, 6:39 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
davide added a comment.Aug 8 2019, 9:45 AM

Did you manage to file a rdar for this issue? If so, can you put the link here for future archeology?

Revision Contents

PathSize
lldb/
trunk/
cmake/
caches/
3 lines

Diff 214137

lldb/trunk/cmake/caches/Apple-lldb-Xcode.cmake

include(${CMAKE_CURRENT_LIST_DIR}/Apple-lldb-base.cmake) include(${CMAKE_CURRENT_LIST_DIR}/Apple-lldb-base.cmake)
set(CMAKE_GENERATOR Xcode CACHE STRING "") set(CMAKE_GENERATOR Xcode CACHE STRING "")
set(CMAKE_OSX_DEPLOYMENT_TARGET 10.11 CACHE STRING "") set(CMAKE_OSX_DEPLOYMENT_TARGET 10.11 CACHE STRING "")
set(CMAKE_XCODE_GENERATE_SCHEME ON CACHE BOOL "") set(CMAKE_XCODE_GENERATE_SCHEME ON CACHE BOOL "")
set(LLDB_BUILD_FRAMEWORK ON CACHE BOOL "") set(LLDB_BUILD_FRAMEWORK ON CACHE BOOL "")
# Apparently, module-enabled builds clash with Xcode's analysis.
set(LLVM_ENABLE_MODULES OFF CACHE BOOL "" FORCE)
# Print a warning with instructions, if we # Print a warning with instructions, if we
# build with Xcode and didn't use this cache. # build with Xcode and didn't use this cache.
set(LLDB_EXPLICIT_XCODE_CACHE_USED ON CACHE INTERNAL "") set(LLDB_EXPLICIT_XCODE_CACHE_USED ON CACHE INTERNAL "")