This is an archive of the discontinued LLVM Phabricator instance.

[Attributor] Introduce checkForAllReadWriteInstructions(...).
ClosedPublic

Authored by sstefan1 on Aug 6 2019, 1:18 PM.

Event Timeline

sstefan1 created this revision.Aug 6 2019, 1:18 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 6 2019, 1:18 PM
jdoerfert accepted this revision.Aug 6 2019, 2:57 PM

One small request, otherwise LGTM.

llvm/include/llvm/Transforms/IPO/Attributor.h
300

bool(Instruction &)

llvm/lib/Transforms/IPO/Attributor.cpp
944

It's much nice now that the concrete AAs don't need to deal with liveness and the infocache etc. but still get the benefits.

This revision is now accepted and ready to land.Aug 6 2019, 2:57 PM
sstefan1 marked 2 inline comments as done.Aug 7 2019, 5:05 AM
sstefan1 added inline comments.
llvm/include/llvm/Transforms/IPO/Attributor.h
300

This will require changes in AANoSync helper functions. I'll change those as well.

llvm/lib/Transforms/IPO/Attributor.cpp
944

Agreed!

sstefan1 updated this revision to Diff 213946.Aug 7 2019, 10:36 AM
  • address comment.
This revision was automatically updated to reflect the committed changes.