Page MenuHomePhabricator

[Attributor][modulemap] Revert r368064 but fix the build
ClosedPublic

Authored by jdoerfert on Aug 6 2019, 12:07 PM.

Details

Summary

Commit r368064 was necessary after r367953 (D65712) broke the module
build. That happened, apparently, because the template class IRAttribute
defined in the header had a virtual method defined in the corresponding
source file (IRAttribute::manifest). To unbreak the situation this patc
introduces a helper function IRAttributeManifest::manifestAttrs which
is used to implement IRAttribute::manifest in the header. The deifnition
of the helper function is still in the source file.

Diff Detail

Repository
rL LLVM

Event Timeline

jdoerfert created this revision.Aug 6 2019, 12:07 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 6 2019, 12:07 PM
jdoerfert marked an inline comment as done.Aug 6 2019, 12:08 PM
jdoerfert added inline comments.
llvm/include/llvm/Transforms/IPO/Attributor.h
668 ↗(On Diff #213681)

forget these two lines of change

kristina accepted this revision.Aug 6 2019, 12:44 PM

Thank you for taking the time to fix this properly, Modules+LTO linked successfully.

This revision is now accepted and ready to land.Aug 6 2019, 12:44 PM
This revision was automatically updated to reflect the committed changes.