This is an archive of the discontinued LLVM Phabricator instance.

[obj2yaml] - MIPS: move and improve testing of the e_flags
ClosedPublic

Authored by grimar on Aug 6 2019, 7:15 AM.

Details

Summary

Mips/elf-flags.yaml and Mips/elf-abi.yaml are tests that intention was to
show that yaml2obj/obj2yaml are able to read/dump MIPS specific e_flags.

They were not complete, contained an excessive YAML parts and were placed
at a wrong location.

I removed them and created the obj2yaml/elf-mips-eflags.yaml instead.

Diff Detail

Repository
rL LLVM

Event Timeline

grimar created this revision.Aug 6 2019, 7:15 AM
grimar planned changes to this revision.Aug 6 2019, 7:21 AM

I am going to rewrite the comments.

I like the idea. But please note that I deleted yaml2obj-elf-file-headers-with-e_flags.yaml at rL368023 because the same functionality is checked by the Mips/elf-flags.yaml. When this patch is applied or as a part of the applying, we can delete Mips/elf-flags.yaml as well.

grimar added a comment.EditedAug 6 2019, 7:46 AM

I like the idea. But please note that I deleted yaml2obj-elf-file-headers-with-e_flags.yaml at rL368023 because the same functionality is checked by the Mips/elf-flags.yaml. When this patch is applied or as a part of the applying, we can delete Mips/elf-flags.yaml as well.

Ok, cool. I did not notice them this time. I see there are 2 tests related there: Mips/elf-abi.yaml and Mips/elf-flags.yaml.
Both of them are incomplete (do not cover all the possible values) and seems contain too much excessive things.
(like section .text or symbol). I am going to remove these 2 in the updated diff.

grimar updated this revision to Diff 213612.Aug 6 2019, 7:52 AM
grimar retitled this revision from [obj2yaml] - Move and improve `test\Object\yaml2obj-elf-file-headers-with-e_flags.yaml` test. to [obj2yaml] - MIPS: move and improve testing of the e_flags.
grimar edited the summary of this revision. (Show Details)
grimar added a reviewer: atanasyan.
grimar removed a subscriber: atanasyan.
grimar updated this revision to Diff 213615.Aug 6 2019, 7:56 AM
  • Simplified.
atanasyan accepted this revision.Aug 6 2019, 8:11 AM

LGTM. Nice

This revision is now accepted and ready to land.Aug 6 2019, 8:11 AM
MaskRay accepted this revision.Aug 6 2019, 9:22 PM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptAug 7 2019, 2:34 AM
Herald added a subscriber: jrtc27. · View Herald Transcript