[yaml2obj][tests] Replace 8-byte `od` conversion with 1-byte conversion

[hubert.reinterpretcast]

Summary

od on AIX does not seem to implement 8-byte integer conversions. Work around this by using 1-byte conversions, which can be used in this case since the value is byte-order insensitive.

[grimar]

LGTM

[MaskRay]

The implementation shall also support the values 1, 2, 4, and 8, even if it provides no C-Language types of those sizes.

Is there a plan that AIX od will implement x8? This case is probably benign but I'm concerned the limitation will make testing harder on most other platforms.

[hubert.reinterpretcast]

In D65671#1613487, @MaskRay wrote:

Is there a plan that AIX od will implement x8?

I've requested the change, but I cannot make any promises on delivery vehicle.

This case is probably benign but I'm concerned the limitation will make testing harder on most other platforms.

I am not sure that it is in the best interest of anyone to use other than x1 unless if they want byte-order-aware conversion for a binary file encoded in the native byte order of the host.

[MaskRay]

In D65671#1613491, @hubert.reinterpretcast wrote:

In D65671#1613487, @MaskRay wrote:

Is there a plan that AIX od will implement x8?

I've requested the change, but I cannot make any promises on delivery vehicle.

This case is probably benign but I'm concerned the limitation will make testing harder on most other platforms.

I am not sure that it is in the best interest of anyone to use other than x1 unless if they want byte-order-aware conversion for a binary file encoded in the native byte order of the host.

I think you meant od is not binary byte-order aware. It makes sense

test/tools/yaml2obj/elf-override-shoffset.yaml

- Name: .strtab
     ShOffset: 0x00000000B
 
 ## Here we check that defining ShOffset does not actually change
 ## the offset at which section data is placed and also does
 ## not affect file size.
 
 # RUN: yaml2obj --docnum=2 %s -o %t2
 # RUN: yaml2obj --docnum=3 %s -o %t3
-# RUN: od -t x8 -v %t2 > %t.txt
-# RUN: od -t x8 -v %t3 >> %t.txt
+# RUN: od -t x1 -v %t2 > %t.txt
+# RUN: od -t x1 -v %t3 >> %t.txt
 # RUN: FileCheck %s --input-file=%t.txt --check-prefix=CASE2
 
-# CASE2: [[OFFSET:.*]] fefefefefefefefe
+# CASE2: [[OFFSET:.*]] fe fe fe fe fe fe fe fe
 # CASE2: [[FILESIZE:.*]]{{$}}
-# CASE2: [[OFFSET]] fefefefefefefefe
+# CASE2: [[OFFSET]] fe fe fe fe fe fe fe fe
 # CASE2: [[FILESIZE]]{{$}}
 
 --- !ELF
 FileHeader:
   Class:   ELFCLASS64
   Data:    ELFDATA2LSB
   Type:    ET_REL
   Machine: EM_X86_64

test/tools/yaml2obj/elf-override-shsize.yaml

- Name: .strtab
     Type: SHT_STRTAB
     ShSize: 0x00000000B
 
 ## Here we check that defining ShSize does not actually change
 ## the content and also does not affect file size.
 
 # RUN: yaml2obj --docnum=2 %s -o %t2
 # RUN: yaml2obj --docnum=3 %s -o %t3
-# RUN: od -t x8 -v %t2 > %t.txt
-# RUN: od -t x8 -v %t3 >> %t.txt
+# RUN: od -t x1 -v %t2 > %t.txt
+# RUN: od -t x1 -v %t3 >> %t.txt
 # RUN: FileCheck %s --input-file=%t.txt --check-prefix=CASE2
 
-# CASE2: [[OFFSET:.*]] fefefefefefefefe
+# CASE2: [[OFFSET:.*]] fe fe fe fe fe fe fe fe
 # CASE2: [[FILESIZE:.*]]{{$}}
-# CASE2: [[OFFSET]] fefefefefefefefe
+# CASE2: [[OFFSET]] fe fe fe fe fe fe fe fe
 # CASE2: [[FILESIZE]]{{$}}
 
 --- !ELF
 FileHeader:
   Class:   ELFCLASS64
   Data:    ELFDATA2LSB
   Type:    ET_REL
   Machine: EM_X86_64