This is an archive of the discontinued LLVM Phabricator instance.

[yaml2obj][tests] Replace 8-byte `od` conversion with 1-byte conversion
ClosedPublic

Authored by hubert.reinterpretcast on Aug 2 2019, 11:39 AM.

Details

Summary

od on AIX does not seem to implement 8-byte integer conversions. Work around this by using 1-byte conversions, which can be used in this case since the value is byte-order insensitive.

Diff Detail

Event Timeline

Herald added a project: Restricted Project. · View Herald TranscriptAug 2 2019, 11:39 AM
grimar accepted this revision.Aug 3 2019, 1:11 AM

LGTM

This revision is now accepted and ready to land.Aug 3 2019, 1:11 AM
MaskRay accepted this revision.Aug 3 2019, 7:46 AM
MaskRay added a subscriber: MaskRay.

The implementation shall also support the values 1, 2, 4, and 8, even if it provides no C-Language types of those sizes.

Is there a plan that AIX od will implement x8? This case is probably benign but I'm concerned the limitation will make testing harder on most other platforms.

Is there a plan that AIX od will implement x8?

I've requested the change, but I cannot make any promises on delivery vehicle.

This case is probably benign but I'm concerned the limitation will make testing harder on most other platforms.

I am not sure that it is in the best interest of anyone to use other than x1 unless if they want byte-order-aware conversion for a binary file encoded in the native byte order of the host.

Is there a plan that AIX od will implement x8?

I've requested the change, but I cannot make any promises on delivery vehicle.

This case is probably benign but I'm concerned the limitation will make testing harder on most other platforms.

I am not sure that it is in the best interest of anyone to use other than x1 unless if they want byte-order-aware conversion for a binary file encoded in the native byte order of the host.

I think you meant od is not binary byte-order aware. It makes sense

This revision was automatically updated to reflect the committed changes.