Page MenuHomePhabricator

[Driver][test] Avoid undefined grep in darwin-ld.c
ClosedPublic

Authored by hubert.reinterpretcast on Aug 2 2019, 11:22 AM.

Details

Summary

question-mark is not a BRE special character.

POSIX.1-2017 XBD Section 9.3.2 indicates that the interpretation of \?
as used by rC366282 is undefined. This patch uses an ERE instead.

Diff Detail

Repository
rL LLVM

Event Timeline

Herald added a project: Restricted Project. · View Herald TranscriptAug 2 2019, 11:23 AM
rnk accepted this revision.Aug 2 2019, 11:26 AM

Probably like most programmers, I am not familiar with section 9.3.2 of posix. I assume this is affecting a real platform that you care about, but I'm curious what it is.

lgtm

This revision is now accepted and ready to land.Aug 2 2019, 11:26 AM
In D65668#1612711, @rnk wrote:

I assume this is affecting a real platform that you care about, but I'm curious what it is.

Yes, this is affecting our tests on AIX. \? there matches a literal ? character.

This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptAug 2 2019, 12:26 PM