Page MenuHomePhabricator

[lldb] [test/lldb-vscode] Use realpath to match vscode behavior
ClosedPublic

Authored by mgorny on Jul 30 2019, 12:13 AM.

Details

Summary

Compare the directory paths returned by lldb-vscode against realpaths
rather than apparent paths. This matches lldb-vscode behavior
and therefore fixes test failures when one of the parent directories
of the source tree is a symlink.

Diff Detail

Repository
rL LLVM

Event Timeline

mgorny created this revision.Jul 30 2019, 12:13 AM
labath accepted this revision.Jul 30 2019, 12:30 AM
labath added a subscriber: labath.

LG, just please replace os.path.split(foo)[0] by os.path.dirname(foo).

This revision is now accepted and ready to land.Jul 30 2019, 12:30 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptJul 30 2019, 12:46 AM