Also update the semantic coloring entry to reflect it being supported in clangd now.
Details
- Reviewers
sammccall - Commits
- rCTE369229: [clangd] Update features table in the docs with links to LSP extension proposals
rGdfe5f3eb0a00: [clangd] Update features table in the docs with links to LSP extension proposals
rL369229: [clangd] Update features table in the docs with links to LSP extension proposals
Diff Detail
- Repository
- rL LLVM
Event Timeline
clang-tools-extra/docs/clangd/Features.rst | ||
---|---|---|
266 ↗ | (On Diff #212075) | Note, I changed "Organize Includes" to "Yes" because it doesn't need a new protocol: it's meant to use textDocument/codeAction (there's even a CodeActionKind for it, source.organizeImports). |
clang-tools-extra/docs/clangd/Features.rst | ||
---|---|---|
260 ↗ | (On Diff #212075) | Could you mention that semantic coloring is implemented in clangd? (with a footnote that it only works in Theia atm) |
269 ↗ | (On Diff #212075) | Having the same marker for three links makes is hard to read. WDYT about using the footnote syntax here? Proposed [1]_ Proposed [2]_ .. [1] https://github.com/microsoft/language-server-protocol/issues/468 .. [2] https://github.com/microsoft/language-server-protocol/issues/136 Just a suggestion, not sure which of the two versions renders nicer. |
Sorry, I had marked this as "accepted", but not hit send. I agree with Ilya's comments, but please go ahead and land this when ready.
(I wish Phabricator didn't say "sammccall accepted this revision" when it's not true - I even went back to check that I'd accepted it)
clang-tools-extra/docs/clangd/Features.rst | ||
---|---|---|
260 ↗ | (On Diff #212075) | Updated. I didn't add a footnote, because it doesn't seem any different than e.g. type hierarchy which I think is also only supported by Theia at the moment -- clangd implements the extension as proposed, and it will work with any client that does as well. |