This is an archive of the discontinued LLVM Phabricator instance.

[AMDGPU][MC] Enabled GFX10 assembly with arbitrary wavesize assumed by the code
ClosedPublic

Authored by dp on Jul 24 2019, 8:37 AM.

Details

Summary

Corrected parser to enable arbitrary valid GFX10 code to be assembled regardless of assumed wavesize.
This is possible with option

-mattr=+WavefrontSize32,+WavefrontSize64

AMD SWDEV-197324

Diff Detail

Event Timeline

dp created this revision.Jul 24 2019, 8:37 AM

Please add some tests for exec/exec_lo.

dp updated this revision to Diff 211525.Jul 24 2019, 9:16 AM

The only GFX10 instructions which use exec affected by wave size are v_cmpx*. But in our assembler they use exec implicitly. So I cannot imagine any relevant tests with exec. I added 2 rather formal tests instead:

v_add_co_u32 v0, exec, v0, v2
v_add_co_u32 v0, exec_lo, v0, v2
This revision is now accepted and ready to land.Jul 24 2019, 9:21 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptJul 24 2019, 9:51 AM