[analyzer] Fix exporting SARIF files from scan-build on Windows

[jranieri-grammatech]

Summary

In Perl, -z is defined as checking if a "file has zero size" and makes no mention what it does when given a directory. It looks like the behavior differs across platforms, which is why on Windows the SARIF file was always being deleted.

[jordan_rose]

Oops. It looks like there's another place where this pattern shows up (see rC139382). The other one should probably be changed as well.

(Thanks for diverging from test(1), perl…)

[jranieri-grammatech]

Update an additional place that used -z.

[NoQ]

Thanks!!

[aaron.ballman]

LGTM! Do you need someone to commit on your behalf?

[jranieri-grammatech]

In D65212#1599841, @aaron.ballman wrote:

LGTM! Do you need someone to commit on your behalf?

Please.

[aaron.ballman]

I've commit on your behalf in r366941, thank you for the patch!

[NoQ]

clang/tools/scan-build/libexec/ccc-analyzer

121

Whoops. I suspect that we're now unconditionally deleting all plist output, which isn't exactly what we wanted. I think we actually wanted to delete empty plist files here.

[jranieri-grammatech]

clang/tools/scan-build/libexec/ccc-analyzer

121

Er, I think you're right. I was out of the office the last few days, but it looks like you've addressed this in rC368338. Thanks!

clang/tools/scan-build/libexec/ccc-analyzer

 my $ReportFailures = $ENV{'CCC_REPORT_FAILURES'};
 if (!defined $ReportFailures) { $ReportFailures = 1; }
 
 my $CleanupFile;
 my $ResultFile;
 
 # Remove any stale files at exit.
 END {
-  if (defined $ResultFile && -z $ResultFile) {
+  if (defined $ResultFile && $ResultFile ne "") {
     unlink($ResultFile);
   }
   if (defined $CleanupFile) {
     unlink($CleanupFile);
   }
 }
 
 ##----------------------------------------------------------------------------##

       push @AnalyzeArgs, "-analyzer-output=" . $OutputFormat;
       if ($OutputFormat =~ /plist/ || $OutputFormat =~ /sarif/) {
         # Change "Output" to be a file.
         my $Suffix = $OutputFormat =~ /plist/ ? ".plist" : ".sarif";
         my ($h, $f) = tempfile("report-XXXXXX", SUFFIX => $Suffix,
                                DIR => $HtmlDir);
         $ResultFile = $f;
         # If the HtmlDir is not set, we should clean up the plist files.
-        if (!defined $HtmlDir || -z $HtmlDir) {
+        if (!defined $HtmlDir || $HtmlDir eq "") {
           $CleanupFile = $f;
         }
       }
     }
     if (defined $ConfigOptions) {
       push @AnalyzeArgs, split '\s+', $ConfigOptions;
     }