Page MenuHomePhabricator

jranieri-grammatech (Joe Ranieri)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 3 2018, 6:01 AM (106 w, 6 d)

Recent Activity

Thu, Oct 1

jranieri-grammatech updated the diff for D54222: [clang-tidy] Add a check to detect returning static locals in public headers.

Do you have data for other projects? As this is not a very common thing and probably different for code-bases with plugins and so on, the "chattiness" of the check would be interesting to know.

Thu, Oct 1, 7:26 AM · Restricted Project, Restricted Project

Thu, Sep 24

jranieri-grammatech added a comment to D54222: [clang-tidy] Add a check to detect returning static locals in public headers.

I agree with @Eugene.Zelenko that this check should rather live in bugprone- as the issue its diagnosing is not LLVM specific. It is ok to add an alias into the llvm module.

Thu, Sep 24, 6:45 PM · Restricted Project, Restricted Project

Sep 18 2020

jranieri-grammatech added a comment to D54222: [clang-tidy] Add a check to detect returning static locals in public headers.

@JonasToth It looks like there are some outstanding review comments that need to be addressed. I've gotten some time allocated to work on this next week.

Sep 18 2020, 6:13 AM · Restricted Project, Restricted Project

May 22 2020

jranieri-grammatech committed rGe4bb3e25e440: [clang-tidy] Expand the list of functions in bugprone-unused-return-value (authored by jranieri-grammatech).
[clang-tidy] Expand the list of functions in bugprone-unused-return-value
May 22 2020, 10:11 AM
jranieri-grammatech closed D76083: [clang-tidy] Expand the list of functions in bugprone-unused-return-value.
May 22 2020, 10:11 AM · Restricted Project

May 7 2020

jranieri-grammatech added a comment to D76083: [clang-tidy] Expand the list of functions in bugprone-unused-return-value.

Ping? It sounds like the consensus is to commit this as-is and, if there's a negative fallout for users of clang-tidy, either split out the functions or pare the list down later?

May 7 2020, 5:55 PM · Restricted Project

Mar 16 2020

jranieri-grammatech added inline comments to D76083: [clang-tidy] Expand the list of functions in bugprone-unused-return-value.
Mar 16 2020, 6:26 AM · Restricted Project
jranieri-grammatech updated the diff for D76083: [clang-tidy] Expand the list of functions in bugprone-unused-return-value.

Removing std::move.

Mar 16 2020, 6:26 AM · Restricted Project

Mar 13 2020

jranieri-grammatech updated the diff for D76083: [clang-tidy] Expand the list of functions in bugprone-unused-return-value.

Adding context.

Mar 13 2020, 8:01 AM · Restricted Project

Mar 12 2020

jranieri-grammatech created D76083: [clang-tidy] Expand the list of functions in bugprone-unused-return-value.
Mar 12 2020, 11:56 AM · Restricted Project

Jan 14 2020

jranieri-grammatech committed rG5ee616a710bc: [analyzer] Fix SARIF column locations (authored by jranieri-grammatech).
[analyzer] Fix SARIF column locations
Jan 14 2020, 12:41 PM
jranieri-grammatech closed D70689: [analyzer] Fix SARIF column locations.
Jan 14 2020, 12:40 PM · Restricted Project

Dec 24 2019

jranieri-grammatech updated the diff for D70689: [analyzer] Fix SARIF column locations.
Dec 24 2019, 7:36 AM · Restricted Project

Dec 23 2019

jranieri-grammatech added inline comments to D70689: [analyzer] Fix SARIF column locations.
Dec 23 2019, 10:29 AM · Restricted Project

Dec 20 2019

jranieri-grammatech added inline comments to D70689: [analyzer] Fix SARIF column locations.
Dec 20 2019, 1:37 PM · Restricted Project
jranieri-grammatech updated the diff for D70689: [analyzer] Fix SARIF column locations.

Addressed review comments.

Dec 20 2019, 1:37 PM · Restricted Project

Nov 25 2019

jranieri-grammatech created D70689: [analyzer] Fix SARIF column locations.
Nov 25 2019, 11:32 AM · Restricted Project

Aug 27 2019

jranieri-grammatech committed rGfce4324f92a0: Update the SARIF exporter to SARIF 2.1 (authored by jranieri-grammatech).
Update the SARIF exporter to SARIF 2.1
Aug 27 2019, 7:55 AM
jranieri-grammatech committed rG3385c5cc4dfd: Fix a SARIF exporter crash with macro expansions (authored by jranieri-grammatech).
Fix a SARIF exporter crash with macro expansions
Aug 27 2019, 7:24 AM
jranieri-grammatech closed D65209: [analyzer] Fix a SARIF exporter crash with macro expansions.
Aug 27 2019, 7:23 AM · Restricted Project
jranieri-grammatech committed rG68a6a28ef835: Fix text range end columns in SARIF to be exclusive (authored by jranieri-grammatech).
Fix text range end columns in SARIF to be exclusive
Aug 27 2019, 6:55 AM
jranieri-grammatech closed D65206: [analyzer] Fix text range end columns in SARIF to be exclusive.
Aug 27 2019, 6:55 AM · Restricted Project
jranieri-grammatech committed rGd0698b67e892: Testing commit access; NFC (authored by jranieri-grammatech).
Testing commit access; NFC
Aug 27 2019, 5:42 AM

Aug 9 2019

jranieri-grammatech added inline comments to D65212: [analyzer] Fix exporting SARIF files from scan-build on Windows.
Aug 9 2019, 5:32 AM · Restricted Project

Jul 24 2019

jranieri-grammatech added a comment to D65212: [analyzer] Fix exporting SARIF files from scan-build on Windows.

LGTM! Do you need someone to commit on your behalf?

Jul 24 2019, 1:00 PM · Restricted Project
jranieri-grammatech updated the diff for D65212: [analyzer] Fix exporting SARIF files from scan-build on Windows.

Update an additional place that used -z.

Jul 24 2019, 12:03 PM · Restricted Project
jranieri-grammatech created D65212: [analyzer] Fix exporting SARIF files from scan-build on Windows.
Jul 24 2019, 7:18 AM · Restricted Project
jranieri-grammatech created D65211: [analyzer] Update the SARIF exporter to SARIF 2.1.
Jul 24 2019, 7:06 AM · Restricted Project, Restricted Project
jranieri-grammatech created D65209: [analyzer] Fix a SARIF exporter crash with macro expansions.
Jul 24 2019, 7:02 AM · Restricted Project
jranieri-grammatech created D65206: [analyzer] Fix text range end columns in SARIF to be exclusive.
Jul 24 2019, 6:23 AM · Restricted Project

Nov 7 2018

jranieri-grammatech created D54222: [clang-tidy] Add a check to detect returning static locals in public headers.
Nov 7 2018, 12:55 PM · Restricted Project, Restricted Project

Nov 4 2018

jranieri-grammatech added a comment to D53778: [CMAKE] Specify all_load when exporting symbols from an executable (macOS).

rC345628 makes Clang depend on llvm::json, so this is no longer relevant for my purposes but I think it is a bit nicer to go this approach than always using -undefined suppress. I'd be okay with abandoning this revision if you'd prefer to keep things as-is.

Nov 4 2018, 7:15 PM
jranieri-grammatech updated the diff for D53778: [CMAKE] Specify all_load when exporting symbols from an executable (macOS).

Specify -bundle_loader when giving a PLUGIN_TOOL to add_llvm_loadable_module. This doesn't limit what executables can load the resulting shared library and just informs the static linker what functions will be present when the library is loaded.

Nov 4 2018, 7:10 PM

Oct 29 2018

jranieri-grammatech added a comment to D53778: [CMAKE] Specify all_load when exporting symbols from an executable (macOS).

I'm not really sure this is the best solution. This will result in bloating the clang binary substantially. An alternative approach would be to use linker order precedence, and pass the LLVM executable first, then LLVM static archives later on the link line. That would allow minimal tool binaries, and link the LLVM bits into your plugin.

Oct 29 2018, 6:59 AM
jranieri-grammatech added a comment to D53781: [ASTMatchers] add a matcher for static locals.

I do.

Oct 29 2018, 6:46 AM

Oct 26 2018

jranieri-grammatech created D53781: [ASTMatchers] add a matcher for static locals.
Oct 26 2018, 3:22 PM
jranieri-grammatech updated the summary of D53778: [CMAKE] Specify all_load when exporting symbols from an executable (macOS).
Oct 26 2018, 2:51 PM
jranieri-grammatech created D53778: [CMAKE] Specify all_load when exporting symbols from an executable (macOS).
Oct 26 2018, 2:51 PM

Oct 9 2018

jranieri-grammatech updated the diff for D52905: [analyzer] fix accessing GDM data from shared libraries.

Added more context.

Oct 9 2018, 9:08 AM
jranieri-grammatech retitled D52906: [analyzer] allow plugins built as shared libraries to receive events from CSA: allow plugins built as shared libraries to receive events to [analyzer] allow plugins built as shared libraries to receive events.
Oct 9 2018, 6:57 AM
jranieri-grammatech retitled D52905: [analyzer] fix accessing GDM data from shared libraries from CSA: fix accessing GDM data from shared libraries to [analyzer] fix accessing GDM data from shared libraries.
Oct 9 2018, 6:54 AM
jranieri-grammatech added a comment to D52905: [analyzer] fix accessing GDM data from shared libraries.
In D52905#1257040, @NoQ wrote:

Hmmm, interesting. A checker doesn't usually need to access these specific static locals, at least not directly. These are usually accessed through functions in .cpp files that are supposed to be compiled with a pointer to the correct instance of the static local, and it doesn't seem to be necessary to expose them to plugins, simply because i don't immediately see why would a plugin want to use them. In this sense, i believe that the entire definition of these traits should be moved to .cpp files and be made private, accessed only via public methods of respective classes. But i guess it's more difficult and it's a separate chunk of work, so i totally approve this patch.

Oct 9 2018, 6:53 AM

Oct 4 2018

jranieri-grammatech created D52906: [analyzer] allow plugins built as shared libraries to receive events.
Oct 4 2018, 1:51 PM
jranieri-grammatech created D52905: [analyzer] fix accessing GDM data from shared libraries.
Oct 4 2018, 1:48 PM