This is an archive of the discontinued LLVM Phabricator instance.

Differential D65211

[analyzer] Update the SARIF exporter to SARIF 2.1
ClosedPublic

Authored by jranieri-grammatech on Jul 24 2019, 7:06 AM.

Details

Reviewers
NoQ
george.karpenkov
aaron.ballman
Commits
rGfce4324f92a0: Update the SARIF exporter to SARIF 2.1
rC370068: Update the SARIF exporter to SARIF 2.1
rL370068: Update the SARIF exporter to SARIF 2.1
Summary

This updates the SARIF exporter to produce SARIF 2.1 output. The bulk of the diffs come from two changes to SARIF:

Diff Detail

Repository
rL LLVM

Event Timeline

jranieri-grammatech created this revision.Jul 24 2019, 7:06 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 24 2019, 7:06 AM
Herald added subscribers: cfe-commits, Charusso, dkrupp and 7 others. · View Herald Transcript
jranieri-grammatech added a parent revision: D65209: [analyzer] Fix a SARIF exporter crash with macro expansions.Jul 24 2019, 7:06 AM
aaron.ballman accepted this revision.Jul 30 2019, 5:35 AM

This LGTM, but I'd appreciate a second reviewer chiming in only because Joe is a coworker.

This revision is now accepted and ready to land.Jul 30 2019, 5:35 AM
aaron.ballman added a comment.Aug 20 2019, 12:36 PM
In D65211#1606089, @aaron.ballman wrote:

This LGTM, but I'd appreciate a second reviewer chiming in only because Joe is a coworker.

Sufficient time has passed that any concerns other reviewers have can be addressed post-commit. Continues to LGTM.

Closed by commit rL370068: Update the SARIF exporter to SARIF 2.1 (authored by jranieri). · Explain WhyAug 27 2019, 7:52 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptAug 27 2019, 7:52 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript

Revision Contents

PathSize
cfe/
trunk/
lib/
StaticAnalyzer/
Core/
85 lines
test/
Analysis/
diagnostics/
Inputs/
expected-sarif/
50 lines
156 lines
2 lines

Diff 217408

cfe/trunk/lib/StaticAnalyzer/Core/SarifDiagnostics.cpp

Show First 20 Lines • Show All 100 Lines • ▼ Show 20 Lines std::for_each(++Iter, End, [&Ret](StringRef Component) {
for (char C : Component) { for (char C : Component) {
Ret += percentEncodeURICharacter(C); Ret += percentEncodeURICharacter(C);
} }
}); });
return Ret.str().str(); return Ret.str().str();
} }
static json::Object createFileLocation(const FileEntry &FE) { static json::Object createArtifactLocation(const FileEntry &FE) {
return json::Object{{"uri", fileNameToURI(getFileName(FE))}}; return json::Object{{"uri", fileNameToURI(getFileName(FE))}};
} }
static json::Object createFile(const FileEntry &FE) { static json::Object createArtifact(const FileEntry &FE) {
return json::Object{{"fileLocation", createFileLocation(FE)}, return json::Object{{"location", createArtifactLocation(FE)},
{"roles", json::Array{"resultFile"}}, {"roles", json::Array{"resultFile"}},
{"length", FE.getSize()}, {"length", FE.getSize()},
{"mimeType", "text/plain"}}; {"mimeType", "text/plain"}};
} }
static json::Object createFileLocation(const FileEntry &FE, static json::Object createArtifactLocation(const FileEntry &FE,
json::Array &Files) { json::Array &Artifacts) {
std::string FileURI = fileNameToURI(getFileName(FE)); std::string FileURI = fileNameToURI(getFileName(FE));
// See if the Files array contains this URI already. If it does not, create // See if the Artifacts array contains this URI already. If it does not,
// a new file object to add to the array. // create a new artifact object to add to the array.
auto I = llvm::find_if(Files, [&](const json::Value &File) { auto I = llvm::find_if(Artifacts, [&](const json::Value &File) {
if (const json::Object *Obj = File.getAsObject()) { if (const json::Object *Obj = File.getAsObject()) {
if (const json::Object *FileLoc = Obj->getObject("fileLocation")) { if (const json::Object *FileLoc = Obj->getObject("location")) {
Optional<StringRef> URI = FileLoc->getString("uri"); Optional<StringRef> URI = FileLoc->getString("uri");
return URI && URI->equals(FileURI); return URI && URI->equals(FileURI);
} }
} }
return false; return false;
}); });
// Calculate the index within the file location array so it can be stored in // Calculate the index within the artifact array so it can be stored in
// the JSON object. // the JSON object.
auto Index = static_cast<unsigned>(std::distance(Files.begin(), I)); auto Index = static_cast<unsigned>(std::distance(Artifacts.begin(), I));
if (I == Files.end()) if (I == Artifacts.end())
Files.push_back(createFile(FE)); Artifacts.push_back(createArtifact(FE));
return json::Object{{"uri", FileURI}, {"fileIndex", Index}}; return json::Object{{"uri", FileURI}, {"index", Index}};
} }
static json::Object createTextRegion(SourceRange R, const SourceManager &SM) { static json::Object createTextRegion(SourceRange R, const SourceManager &SM) {
json::Object Region{ json::Object Region{
{"startLine", SM.getExpansionLineNumber(R.getBegin())}, {"startLine", SM.getExpansionLineNumber(R.getBegin())},
{"startColumn", SM.getExpansionColumnNumber(R.getBegin())}, {"startColumn", SM.getExpansionColumnNumber(R.getBegin())},
}; };
if (R.getBegin() == R.getEnd()) { if (R.getBegin() == R.getEnd()) {
Region["endColumn"] = SM.getExpansionColumnNumber(R.getBegin()); Region["endColumn"] = SM.getExpansionColumnNumber(R.getBegin());
} else { } else {
Region["endLine"] = SM.getExpansionLineNumber(R.getEnd()); Region["endLine"] = SM.getExpansionLineNumber(R.getEnd());
Region["endColumn"] = SM.getExpansionColumnNumber(R.getEnd()) + 1; Region["endColumn"] = SM.getExpansionColumnNumber(R.getEnd()) + 1;
} }
return Region; return Region;
} }
static json::Object createPhysicalLocation(SourceRange R, const FileEntry &FE, static json::Object createPhysicalLocation(SourceRange R, const FileEntry &FE,
const SourceManager &SMgr, const SourceManager &SMgr,
json::Array &Files) { json::Array &Artifacts) {
return json::Object{{{"fileLocation", createFileLocation(FE, Files)}, return json::Object{
{{"artifactLocation", createArtifactLocation(FE, Artifacts)},
{"region", createTextRegion(R, SMgr)}}}; {"region", createTextRegion(R, SMgr)}}};
} }
enum class Importance { Important, Essential, Unimportant }; enum class Importance { Important, Essential, Unimportant };
static StringRef importanceToStr(Importance I) { static StringRef importanceToStr(Importance I) {
switch (I) { switch (I) {
case Importance::Important: case Importance::Important:
return "important"; return "important";
Show All 36 Lines return Piece.getTagStr() == "ConditionBRVisitor" ? Importance::Important
: Importance::Essential; : Importance::Essential;
case PathDiagnosticPiece::ControlFlow: case PathDiagnosticPiece::ControlFlow:
return Importance::Unimportant; return Importance::Unimportant;
} }
return Importance::Unimportant; return Importance::Unimportant;
} }
static json::Object createThreadFlow(const PathPieces &Pieces, static json::Object createThreadFlow(const PathPieces &Pieces,
json::Array &Files) { json::Array &Artifacts) {
const SourceManager &SMgr = Pieces.front()->getLocation().getManager(); const SourceManager &SMgr = Pieces.front()->getLocation().getManager();
json::Array Locations; json::Array Locations;
for (const auto &Piece : Pieces) { for (const auto &Piece : Pieces) {
const PathDiagnosticLocation &P = Piece->getLocation(); const PathDiagnosticLocation &P = Piece->getLocation();
Locations.push_back(createThreadFlowLocation( Locations.push_back(createThreadFlowLocation(
createLocation(createPhysicalLocation( createLocation(createPhysicalLocation(
P.asRange(), P.asRange(),
*P.asLocation().getExpansionLoc().getFileEntry(), *P.asLocation().getExpansionLoc().getFileEntry(),
SMgr, Files), SMgr, Artifacts),
Piece->getString()), Piece->getString()),
calculateImportance(*Piece))); calculateImportance(*Piece)));
} }
return json::Object{{"locations", std::move(Locations)}}; return json::Object{{"locations", std::move(Locations)}};
} }
static json::Object createCodeFlow(const PathPieces &Pieces, static json::Object createCodeFlow(const PathPieces &Pieces,
json::Array &Files) { json::Array &Artifacts) {
return json::Object{ return json::Object{
{"threadFlows", json::Array{createThreadFlow(Pieces, Files)}}}; {"threadFlows", json::Array{createThreadFlow(Pieces, Artifacts)}}};
}
static json::Object createTool() {
return json::Object{{"name", "clang"},
{"fullName", "clang static analyzer"},
{"language", "en-US"},
{"version", getClangFullVersion()}};
} }
static json::Object createResult(const PathDiagnostic &Diag, json::Array &Files, static json::Object createResult(const PathDiagnostic &Diag,
json::Array &Artifacts,
const StringMap<unsigned> &RuleMapping) { const StringMap<unsigned> &RuleMapping) {
const PathPieces &Path = Diag.path.flatten(false); const PathPieces &Path = Diag.path.flatten(false);
const SourceManager &SMgr = Path.front()->getLocation().getManager(); const SourceManager &SMgr = Path.front()->getLocation().getManager();
auto Iter = RuleMapping.find(Diag.getCheckName()); auto Iter = RuleMapping.find(Diag.getCheckName());
assert(Iter != RuleMapping.end() && "Rule ID is not in the array index map?"); assert(Iter != RuleMapping.end() && "Rule ID is not in the array index map?");
return json::Object{ return json::Object{
{"message", createMessage(Diag.getVerboseDescription())}, {"message", createMessage(Diag.getVerboseDescription())},
{"codeFlows", json::Array{createCodeFlow(Path, Files)}}, {"codeFlows", json::Array{createCodeFlow(Path, Artifacts)}},
{"locations", {"locations",
json::Array{createLocation(createPhysicalLocation( json::Array{createLocation(createPhysicalLocation(
Diag.getLocation().asRange(), Diag.getLocation().asRange(),
*Diag.getLocation().asLocation().getExpansionLoc().getFileEntry(), *Diag.getLocation().asLocation().getExpansionLoc().getFileEntry(),
SMgr, Files))}}, SMgr, Artifacts))}},
{"ruleIndex", Iter->getValue()}, {"ruleIndex", Iter->getValue()},
{"ruleId", Diag.getCheckName()}}; {"ruleId", Diag.getCheckName()}};
} }
static StringRef getRuleDescription(StringRef CheckName) { static StringRef getRuleDescription(StringRef CheckName) {
return llvm::StringSwitch<StringRef>(CheckName) return llvm::StringSwitch<StringRef>(CheckName)
#define GET_CHECKERS #define GET_CHECKERS
#define CHECKER(FULLNAME, CLASS, HELPTEXT, DOC_URI, IS_HIDDEN) \ #define CHECKER(FULLNAME, CLASS, HELPTEXT, DOC_URI, IS_HIDDEN) \
Show All 14 Lines
#undef GET_CHECKERS #undef GET_CHECKERS
; ;
} }
static json::Object createRule(const PathDiagnostic &Diag) { static json::Object createRule(const PathDiagnostic &Diag) {
StringRef CheckName = Diag.getCheckName(); StringRef CheckName = Diag.getCheckName();
json::Object Ret{ json::Object Ret{
{"fullDescription", createMessage(getRuleDescription(CheckName))}, {"fullDescription", createMessage(getRuleDescription(CheckName))},
{"name", createMessage(CheckName)}, {"name", CheckName},
{"id", CheckName}}; {"id", CheckName}};
std::string RuleURI = getRuleHelpURIStr(CheckName); std::string RuleURI = getRuleHelpURIStr(CheckName);
if (!RuleURI.empty()) if (!RuleURI.empty())
Ret["helpUri"] = RuleURI; Ret["helpUri"] = RuleURI;
return Ret; return Ret;
} }
Show All 10 Lines if (P.second) {
RuleMapping[RuleID] = Rules.size(); // Maps RuleID to an Array Index. RuleMapping[RuleID] = Rules.size(); // Maps RuleID to an Array Index.
Rules.push_back(createRule(*D)); Rules.push_back(createRule(*D));
} }
}); });
return Rules; return Rules;
} }
static json::Object createResources(std::vector<const PathDiagnostic *> &Diags, static json::Object createTool(std::vector<const PathDiagnostic *> &Diags,
StringMap<unsigned> &RuleMapping) { StringMap<unsigned> &RuleMapping) {
return json::Object{{"rules", createRules(Diags, RuleMapping)}}; return json::Object{
{"driver", json::Object{{"name", "clang"},
{"fullName", "clang static analyzer"},
{"language", "en-US"},
{"version", getClangFullVersion()},
{"rules", createRules(Diags, RuleMapping)}}}};
} }
static json::Object createRun(std::vector<const PathDiagnostic *> &Diags) { static json::Object createRun(std::vector<const PathDiagnostic *> &Diags) {
json::Array Results, Files; json::Array Results, Artifacts;
StringMap<unsigned> RuleMapping; StringMap<unsigned> RuleMapping;
json::Object Resources = createResources(Diags, RuleMapping); json::Object Tool = createTool(Diags, RuleMapping);
llvm::for_each(Diags, [&](const PathDiagnostic *D) { llvm::for_each(Diags, [&](const PathDiagnostic *D) {
Results.push_back(createResult(*D, Files, RuleMapping)); Results.push_back(createResult(*D, Artifacts, RuleMapping));
}); });
return json::Object{{"tool", createTool()}, return json::Object{{"tool", std::move(Tool)},
{"resources", std::move(Resources)},
{"results", std::move(Results)}, {"results", std::move(Results)},
{"files", std::move(Files)}}; {"artifacts", std::move(Artifacts)}};
} }
void SarifDiagnostics::FlushDiagnosticsImpl( void SarifDiagnostics::FlushDiagnosticsImpl(
std::vector<const PathDiagnostic *> &Diags, FilesMade *) { std::vector<const PathDiagnostic *> &Diags, FilesMade *) {
// We currently overwrite the file if it already exists. However, it may be // We currently overwrite the file if it already exists. However, it may be
// useful to add a feature someday that allows the user to append a run to an // useful to add a feature someday that allows the user to append a run to an
// existing SARIF file. One danger from that approach is that the size of the // existing SARIF file. One danger from that approach is that the size of the
// file can become large very quickly, so decoding into JSON to append a run // file can become large very quickly, so decoding into JSON to append a run
// may be an expensive operation. // may be an expensive operation.
std::error_code EC; std::error_code EC;
llvm::raw_fd_ostream OS(OutputFile, EC, llvm::sys::fs::OF_Text); llvm::raw_fd_ostream OS(OutputFile, EC, llvm::sys::fs::OF_Text);
if (EC) { if (EC) {
llvm::errs() << "warning: could not create file: " << EC.message() << '\n'; llvm::errs() << "warning: could not create file: " << EC.message() << '\n';
return; return;
} }
json::Object Sarif{ json::Object Sarif{
{"$schema", {"$schema",
"http://json.schemastore.org/sarif-2.0.0-csd.2.beta.2018-11-28"}, "https://raw.githubusercontent.com/oasis-tcs/sarif-spec/master/Schemata/sarif-schema-2.1.0.json"},
{"version", "2.0.0-csd.2.beta.2018-11-28"}, {"version", "2.1.0"},
{"runs", json::Array{createRun(Diags)}}}; {"runs", json::Array{createRun(Diags)}}};
OS << llvm::formatv("{0:2}\n", json::Value(std::move(Sarif))); OS << llvm::formatv("{0:2}\n", json::Value(std::move(Sarif)));
} }

cfe/trunk/test/Analysis/diagnostics/Inputs/expected-sarif/sarif-diagnostics-taint-test.c.sarif

{ {
"$schema": "http://json.schemastore.org/sarif-2.0.0-csd.2.beta.2018-11-28", "$schema": "https://raw.githubusercontent.com/oasis-tcs/sarif-spec/master/Schemata/sarif-schema-2.1.0.json",
"runs": [ "runs": [
{ {
"files": [ "artifacts": [
{ {
"fileLocation": {
},
"length": 434, "length": 434,
"location": {
},
"mimeType": "text/plain", "mimeType": "text/plain",
"roles": [ "roles": [
"resultFile" "resultFile"
] ]
} }
], ],
"resources": {
"rules": [
{
"fullDescription": {
"text": "Mark tainted symbols as such."
},
"id": "debug.TaintTest",
"name": {
"text": "debug.TaintTest"
}
}
]
},
"results": [ "results": [
{ {
"codeFlows": [ "codeFlows": [
{ {
"threadFlows": [ "threadFlows": [
{ {
"locations": [ "locations": [
{ {
"importance": "essential", "importance": "essential",
"location": { "location": {
"message": { "message": {
"text": "Calling 'f'" "text": "Calling 'f'"
}, },
"physicalLocation": { "physicalLocation": {
"fileLocation": { "artifactLocation": {
"fileIndex": 0, "index": 0,
}, },
"region": { "region": {
"endColumn": 6, "endColumn": 6,
"endLine": 13, "endLine": 13,
"startColumn": 3, "startColumn": 3,
"startLine": 13 "startLine": 13
} }
} }
} }
}, },
{ {
"importance": "essential", "importance": "essential",
"location": { "location": {
"message": { "message": {
"text": "tainted" "text": "tainted"
}, },
"physicalLocation": { "physicalLocation": {
"fileLocation": { "artifactLocation": {
"fileIndex": 0, "index": 0,
}, },
"region": { "region": {
"endColumn": 18, "endColumn": 18,
"endLine": 9, "endLine": 9,
"startColumn": 11, "startColumn": 11,
"startLine": 9 "startLine": 9
} }
} }
} }
} }
] ]
} }
] ]
} }
], ],
"locations": [ "locations": [
{ {
"physicalLocation": { "physicalLocation": {
"fileLocation": { "artifactLocation": {
"fileIndex": 0, "index": 0,
}, },
"region": { "region": {
"endColumn": 18, "endColumn": 18,
"endLine": 9, "endLine": 9,
"startColumn": 11, "startColumn": 11,
"startLine": 9 "startLine": 9
} }
} }
} }
], ],
"message": { "message": {
"text": "tainted" "text": "tainted"
}, },
"ruleId": "debug.TaintTest", "ruleId": "debug.TaintTest",
"ruleIndex": 0 "ruleIndex": 0
} }
], ],
"tool": { "tool": {
"driver": {
"fullName": "clang static analyzer", "fullName": "clang static analyzer",
"language": "en-US", "language": "en-US",
"name": "clang", "name": "clang",
"rules": [
{
"fullDescription": {
"text": "Mark tainted symbols as such."
},
"id": "debug.TaintTest",
"name": "debug.TaintTest"
}
],
}
} }
} }
], ],
} }

cfe/trunk/test/Analysis/diagnostics/Inputs/expected-sarif/sarif-multi-diagnostic-test.c.sarif

{ {
"$schema": "http://json.schemastore.org/sarif-2.0.0-csd.2.beta.2018-11-28", "$schema": "https://raw.githubusercontent.com/oasis-tcs/sarif-spec/master/Schemata/sarif-schema-2.1.0.json",
"runs": [ "runs": [
{ {
"files": [ "artifacts": [
{ {
"fileLocation": {
},
"length": 951, "length": 951,
"location": {
},
"mimeType": "text/plain", "mimeType": "text/plain",
"roles": [ "roles": [
"resultFile" "resultFile"
] ]
} }
], ],
"resources": {
"rules": [
{
"fullDescription": {
"text": "Mark tainted symbols as such."
},
"id": "debug.TaintTest",
"name": {
"text": "debug.TaintTest"
}
},
{
"fullDescription": {
"text": "Check for logical errors for function calls and Objective-C message expressions (e.g., uninitialized arguments, null function pointers)"
},
"helpUri": "https://clang-analyzer.llvm.org/available_checks.html#core.CallAndMessage",
"id": "core.CallAndMessage",
"name": {
"text": "core.CallAndMessage"
}
},
{
"fullDescription": {
"text": "Check for division by zero"
},
"helpUri": "https://clang-analyzer.llvm.org/available_checks.html#core.DivideZero",
"id": "core.DivideZero",
"name": {
"text": "core.DivideZero"
}
},
{
"fullDescription": {
"text": "Check for memory leaks, double free, and use-after-free problems. Traces memory managed by malloc()/free()."
},
"helpUri": "https://clang-analyzer.llvm.org/available_checks.html#unix.Malloc",
"id": "unix.Malloc",
"name": {
"text": "unix.Malloc"
}
}
]
},
"results": [ "results": [
{ {
"codeFlows": [ "codeFlows": [
{ {
"threadFlows": [ "threadFlows": [
{ {
"locations": [ "locations": [
{ {
"importance": "essential", "importance": "essential",
"location": { "location": {
"message": { "message": {
"text": "Calling 'f'" "text": "Calling 'f'"
}, },
"physicalLocation": { "physicalLocation": {
"fileLocation": { "artifactLocation": {
"fileIndex": 0, "index": 0,
}, },
"region": { "region": {
"endColumn": 6, "endColumn": 6,
"endLine": 34, "endLine": 34,
"startColumn": 3, "startColumn": 3,
"startLine": 34 "startLine": 34
} }
} }
} }
}, },
{ {
"importance": "essential", "importance": "essential",
"location": { "location": {
"message": { "message": {
"text": "tainted" "text": "tainted"
}, },
"physicalLocation": { "physicalLocation": {
"fileLocation": { "artifactLocation": {
"fileIndex": 0, "index": 0,
}, },
"region": { "region": {
"endColumn": 18, "endColumn": 18,
"endLine": 11, "endLine": 11,
"startColumn": 11, "startColumn": 11,
"startLine": 11 "startLine": 11
} }
} }
} }
} }
] ]
} }
] ]
} }
], ],
"locations": [ "locations": [
{ {
"physicalLocation": { "physicalLocation": {
"fileLocation": { "artifactLocation": {
"fileIndex": 0, "index": 0,
}, },
"region": { "region": {
"endColumn": 18, "endColumn": 18,
"endLine": 11, "endLine": 11,
"startColumn": 11, "startColumn": 11,
"startLine": 11 "startLine": 11
} }
} }
Show All 13 Lines "runs": [
"locations": [ "locations": [
{ {
"importance": "essential", "importance": "essential",
"location": { "location": {
"message": { "message": {
"text": "Calling 'g'" "text": "Calling 'g'"
}, },
"physicalLocation": { "physicalLocation": {
"fileLocation": { "artifactLocation": {
"fileIndex": 0, "index": 0,
}, },
"region": { "region": {
"endColumn": 6, "endColumn": 6,
"endLine": 35, "endLine": 35,
"startColumn": 3, "startColumn": 3,
"startLine": 35 "startLine": 35
} }
} }
} }
}, },
{ {
"importance": "essential", "importance": "essential",
"location": { "location": {
"message": { "message": {
"text": "'fp' declared without an initial value" "text": "'fp' declared without an initial value"
}, },
"physicalLocation": { "physicalLocation": {
"fileLocation": { "artifactLocation": {
"fileIndex": 0, "index": 0,
}, },
"region": { "region": {
"endColumn": 11, "endColumn": 11,
"endLine": 15, "endLine": 15,
"startColumn": 3, "startColumn": 3,
"startLine": 15 "startLine": 15
} }
} }
} }
}, },
{ {
"importance": "essential", "importance": "essential",
"location": { "location": {
"message": { "message": {
"text": "Called function pointer is an uninitialized pointer value" "text": "Called function pointer is an uninitialized pointer value"
}, },
"physicalLocation": { "physicalLocation": {
"fileLocation": { "artifactLocation": {
"fileIndex": 0, "index": 0,
}, },
"region": { "region": {
"endColumn": 9, "endColumn": 9,
"endLine": 16, "endLine": 16,
"startColumn": 3, "startColumn": 3,
"startLine": 16 "startLine": 16
} }
} }
} }
} }
] ]
} }
] ]
} }
], ],
"locations": [ "locations": [
{ {
"physicalLocation": { "physicalLocation": {
"fileLocation": { "artifactLocation": {
"fileIndex": 0, "index": 0,
}, },
"region": { "region": {
"endColumn": 9, "endColumn": 9,
"endLine": 16, "endLine": 16,
"startColumn": 3, "startColumn": 3,
"startLine": 16 "startLine": 16
} }
} }
Show All 13 Lines "runs": [
"locations": [ "locations": [
{ {
"importance": "important", "importance": "important",
"location": { "location": {
"message": { "message": {
"text": "Assuming 'i' is equal to 0" "text": "Assuming 'i' is equal to 0"
}, },
"physicalLocation": { "physicalLocation": {
"fileLocation": { "artifactLocation": {
"fileIndex": 0, "index": 0,
}, },
"region": { "region": {
"endColumn": 13, "endColumn": 13,
"endLine": 20, "endLine": 20,
"startColumn": 7, "startColumn": 7,
"startLine": 20 "startLine": 20
} }
} }
} }
}, },
{ {
"importance": "unimportant", "importance": "unimportant",
"location": { "location": {
"message": { "message": {
"text": "Taking true branch" "text": "Taking true branch"
}, },
"physicalLocation": { "physicalLocation": {
"fileLocation": { "artifactLocation": {
"fileIndex": 0, "index": 0,
}, },
"region": { "region": {
"endColumn": 3, "endColumn": 3,
"startColumn": 3, "startColumn": 3,
"startLine": 20 "startLine": 20
} }
} }
} }
}, },
{ {
"importance": "essential", "importance": "essential",
"location": { "location": {
"message": { "message": {
"text": "Division by zero" "text": "Division by zero"
}, },
"physicalLocation": { "physicalLocation": {
"fileLocation": { "artifactLocation": {
"fileIndex": 0, "index": 0,
}, },
"region": { "region": {
"endColumn": 14, "endColumn": 14,
"startColumn": 14, "startColumn": 14,
"startLine": 21 "startLine": 21
} }
} }
} }
} }
] ]
} }
] ]
} }
], ],
"locations": [ "locations": [
{ {
"physicalLocation": { "physicalLocation": {
"fileLocation": { "artifactLocation": {
"fileIndex": 0, "index": 0,
}, },
"region": { "region": {
"endColumn": 14, "endColumn": 14,
"startColumn": 14, "startColumn": 14,
"startLine": 21 "startLine": 21
} }
} }
} }
Show All 12 Lines "runs": [
"locations": [ "locations": [
{ {
"importance": "essential", "importance": "essential",
"location": { "location": {
"message": { "message": {
"text": "Memory is allocated" "text": "Memory is allocated"
}, },
"physicalLocation": { "physicalLocation": {
"fileLocation": { "artifactLocation": {
"fileIndex": 0, "index": 0,
}, },
"region": { "region": {
"endColumn": 24, "endColumn": 24,
"endLine": 26, "endLine": 26,
"startColumn": 15, "startColumn": 15,
"startLine": 26 "startLine": 26
} }
} }
} }
}, },
{ {
"importance": "important", "importance": "important",
"location": { "location": {
"message": { "message": {
"text": "Assuming 'i' is < 4" "text": "Assuming 'i' is < 4"
}, },
"physicalLocation": { "physicalLocation": {
"fileLocation": { "artifactLocation": {
"fileIndex": 0, "index": 0,
}, },
"region": { "region": {
"endColumn": 12, "endColumn": 12,
"endLine": 27, "endLine": 27,
"startColumn": 7, "startColumn": 7,
"startLine": 27 "startLine": 27
} }
} }
} }
}, },
{ {
"importance": "unimportant", "importance": "unimportant",
"location": { "location": {
"message": { "message": {
"text": "Taking true branch" "text": "Taking true branch"
}, },
"physicalLocation": { "physicalLocation": {
"fileLocation": { "artifactLocation": {
"fileIndex": 0, "index": 0,
}, },
"region": { "region": {
"endColumn": 3, "endColumn": 3,
"startColumn": 3, "startColumn": 3,
"startLine": 27 "startLine": 27
} }
} }
} }
}, },
{ {
"importance": "essential", "importance": "essential",
"location": { "location": {
"message": { "message": {
"text": "Potential leak of memory pointed to by 'mem'" "text": "Potential leak of memory pointed to by 'mem'"
}, },
"physicalLocation": { "physicalLocation": {
"fileLocation": { "artifactLocation": {
"fileIndex": 0, "index": 0,
}, },
"region": { "region": {
"endColumn": 12, "endColumn": 12,
"startColumn": 12, "startColumn": 12,
"startLine": 28 "startLine": 28
} }
} }
} }
} }
] ]
} }
] ]
} }
], ],
"locations": [ "locations": [
{ {
"physicalLocation": { "physicalLocation": {
"fileLocation": { "artifactLocation": {
"fileIndex": 0, "index": 0,
}, },
"region": { "region": {
"endColumn": 12, "endColumn": 12,
"startColumn": 12, "startColumn": 12,
"startLine": 28 "startLine": 28
} }
} }
} }
], ],
"message": { "message": {
"text": "Potential leak of memory pointed to by 'mem'" "text": "Potential leak of memory pointed to by 'mem'"
}, },
"ruleId": "unix.Malloc", "ruleId": "unix.Malloc",
"ruleIndex": 3 "ruleIndex": 3
} }
], ],
"tool": { "tool": {
"driver": {
"fullName": "clang static analyzer", "fullName": "clang static analyzer",
"language": "en-US", "language": "en-US",
"name": "clang", "name": "clang",
"rules": [
{
"fullDescription": {
"text": "Mark tainted symbols as such."
},
"id": "debug.TaintTest",
"name": "debug.TaintTest"
},
{
"fullDescription": {
"text": "Check for logical errors for function calls and Objective-C message expressions (e.g., uninitialized arguments, null function pointers)"
},
"helpUri": "https://clang-analyzer.llvm.org/available_checks.html#core.CallAndMessage",
"id": "core.CallAndMessage",
"name": "core.CallAndMessage"
},
{
"fullDescription": {
"text": "Check for division by zero"
},
"helpUri": "https://clang-analyzer.llvm.org/available_checks.html#core.DivideZero",
"id": "core.DivideZero",
"name": "core.DivideZero"
},
{
"fullDescription": {
"text": "Check for memory leaks, double free, and use-after-free problems. Traces memory managed by malloc()/free()."
},
"helpUri": "https://clang-analyzer.llvm.org/available_checks.html#unix.Malloc",
"id": "unix.Malloc",
"name": "unix.Malloc"
}
],
}
} }
} }
], ],
} }

cfe/trunk/test/Analysis/lit.local.cfg

Show All 16 Lines "grep -Ev '%s|%s|%s'" %
'^[[:space:]]*<string>/.*</string>[[:space:]]*$', '^[[:space:]]*<string>/.*</string>[[:space:]]*$',
'^[[:space:]]*<string>.:.*</string>[[:space:]]*$'))) '^[[:space:]]*<string>.:.*</string>[[:space:]]*$')))
# Filtering command for testing SARIF output against reference output. # Filtering command for testing SARIF output against reference output.
config.substitutions.append(('%normalize_sarif', config.substitutions.append(('%normalize_sarif',
"grep -Ev '^[[:space:]]*(%s|%s|%s)[[:space:]]*$'" % "grep -Ev '^[[:space:]]*(%s|%s|%s)[[:space:]]*$'" %
('"uri": "file:.*%basename_t"', ('"uri": "file:.*%basename_t"',
'"version": ".* version .*"', '"version": ".* version .*"',
'"version": "2\.0\.0-csd\.[0-9]*\.beta\.[0-9-]{10}"'))) '"version": "2.1.0"')))
if not config.root.clang_staticanalyzer: if not config.root.clang_staticanalyzer:
config.unsupported = True config.unsupported = True