This is an archive of the discontinued LLVM Phabricator instance.

Differential D65116

[Driver] Set the default win32-macho debug format to DWARF
ClosedPublic

Authored by vsk on Jul 22 2019, 2:31 PM.

Details

Reviewers
ahatanak
JDevlieghere
friss
davide
Commits
rG7b124c0903d4: [Driver] Set the default win32-macho debug format to DWARF
rC366744: [Driver] Set the default win32-macho debug format to DWARF
rL366744: [Driver] Set the default win32-macho debug format to DWARF
Summary

rdar://53267670

Diff Detail

Event Timeline

vsk created this revision.Jul 22 2019, 2:31 PM
Herald added a subscriber: dexonsmith. · View Herald TranscriptJul 22 2019, 2:31 PM
JDevlieghere accepted this revision.Jul 22 2019, 2:39 PM
This revision is now accepted and ready to land.Jul 22 2019, 2:39 PM
JDevlieghere added inline comments.Jul 22 2019, 2:40 PM
clang/lib/Driver/ToolChains/MSVC.h
81

Let's update the comment.

davide accepted this revision.Jul 22 2019, 2:43 PM
davide added a subscriber: davide.

Minor otherwise LGTM

Closed by commit rL366744: [Driver] Set the default win32-macho debug format to DWARF (authored by vedantk). · Explain WhyJul 22 2019, 2:47 PM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptJul 22 2019, 2:47 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript

Revision Contents

PathSize
clang/
lib/
Driver/
ToolChains/
3 lines
test/
Misc/
3 lines

Diff 211192

clang/lib/Driver/ToolChains/MSVC.h

Show First 20 Lines • Show All 72 Lines • ▼ Show 20 Lines TranslateArgs(const llvm::opt::DerivedArgList &Args, StringRef BoundArch,
Action::OffloadKind DeviceOffloadKind) const override; Action::OffloadKind DeviceOffloadKind) const override;
bool IsIntegratedAssemblerDefault() const override; bool IsIntegratedAssemblerDefault() const override;
bool IsUnwindTablesDefault(const llvm::opt::ArgList &Args) const override; bool IsUnwindTablesDefault(const llvm::opt::ArgList &Args) const override;
bool isPICDefault() const override; bool isPICDefault() const override;
bool isPIEDefault() const override; bool isPIEDefault() const override;
bool isPICDefaultForced() const override; bool isPICDefaultForced() const override;
/// Set CodeView as the default debug info format. Users can use -gcodeview /// Set CodeView as the default debug info format. Users can use -gcodeview
JDevlieghereUnsubmitted
Not Done
ReplyInline Actions

Let's update the comment.

JDevlieghere: Let's update the comment.
/// and -gdwarf to override the default. /// and -gdwarf to override the default.
codegenoptions::DebugInfoFormat getDefaultDebugFormat() const override { codegenoptions::DebugInfoFormat getDefaultDebugFormat() const override {
return codegenoptions::DIF_CodeView; return getTriple().isOSBinFormatMachO() ? codegenoptions::DIF_DWARF
: codegenoptions::DIF_CodeView;
} }
/// Set the debugger tuning to "default", since we're definitely not tuning /// Set the debugger tuning to "default", since we're definitely not tuning
/// for GDB. /// for GDB.
llvm::DebuggerKind getDefaultDebuggerTuning() const override { llvm::DebuggerKind getDefaultDebuggerTuning() const override {
return llvm::DebuggerKind::Default; return llvm::DebuggerKind::Default;
} }
▲ Show 20 Lines • Show All 68 Lines • Show Last 20 Lines

clang/test/Misc/win32-macho.c

// Check that basic use of win32-macho targets works. // Check that basic use of win32-macho targets works.
// RUN: %clang -fsyntax-only -target x86_64-pc-win32-macho %s // RUN: %clang -fsyntax-only -target x86_64-pc-win32-macho %s
// RUN: %clang -fsyntax-only -target x86_64-pc-win32-macho -g %s -### 2>&1 | FileCheck %s -check-prefix=DEBUG-INFO
// DEBUG-INFO: -dwarf-version={{.*}}