This is an archive of the discontinued LLVM Phabricator instance.

Allow for vendor prefixes in a list test
ClosedPublic

Authored by lanza on Jul 15 2019, 2:35 PM.

Details

Summary

Preprocessor/init.c contains a line that explicitly checks for the
string

VERSION "Clang{{.*}}

It's valid to have a toolchain configured to emit a vendor prefix
before the word Clang. e.g.

VERSION "Vendor Clang{{.*}}

Diff Detail

Repository
rL LLVM

Event Timeline

lanza created this revision.Jul 15 2019, 2:35 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 15 2019, 2:35 PM
compnerd accepted this revision.Jul 15 2019, 4:36 PM

Yeah, that makes sense, the common path uses {{.*}} as the value itself is uninteresting.

This revision is now accepted and ready to land.Jul 15 2019, 4:36 PM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptJul 15 2019, 5:58 PM