This is an archive of the discontinued LLVM Phabricator instance.

Differential D64614

[clangd] Mark type hierarchy as a supported feature in the docs
ClosedPublic

Authored by nridge on Jul 11 2019, 8:33 PM.

Details

Reviewers
sammccall
Commits
rGd1fdadb22685: [clangd] Mark type hierarchy as a supported feature in the docs
rCTE365987: [clangd] Mark type hierarchy as a supported feature in the docs
rL365987: [clangd] Mark type hierarchy as a supported feature in the docs

Diff Detail

Event Timeline

nridge created this revision.Jul 11 2019, 8:33 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 11 2019, 8:33 PM
Herald added subscribers: cfe-commits, kadircet, arphaman and 3 others. · View Herald Transcript
Harbormaster completed remote builds in B34841: Diff 209408.Jul 11 2019, 8:33 PM
nridge marked an inline comment as done.Jul 11 2019, 8:34 PM
nridge added inline comments.
clang-tools-extra/docs/clangd/Features.rst
264

Should I perhaps change type hierarchy's entry in the LSP column from "No" to "Proposed"?

sammccall accepted this revision.Jul 12 2019, 2:24 AM
sammccall added inline comments.
clang-tools-extra/docs/clangd/Features.rst
264

I'm not sure what "no" means, if it doesn't mean "proposed".

Changing the "no" links to say "proposal" and link to it would be useful, I think.
(And we could delete any rows that don't have a proposal)

This revision is now accepted and ready to land.Jul 12 2019, 2:24 AM
Closed by commit rL365987: [clangd] Mark type hierarchy as a supported feature in the docs (authored by nridge). · Explain WhyJul 12 2019, 8:25 PM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptJul 12 2019, 8:25 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
nridge marked an inline comment as done.Jul 12 2019, 8:26 PM
nridge added inline comments.
clang-tools-extra/docs/clangd/Features.rst
264

Good idea -- I'll look at that in a separate commit.

malaperle added a subscriber: malaperle.Jul 12 2019, 8:48 PM
malaperle added inline comments.
clang-tools-extra/docs/clangd/Features.rst
264

The rows that have "no" and don't have proposals meant that we wanted to make proposals for the LSP eventually in order to match other IDEs feature. Many didn't have proposals at the time.

nridge marked an inline comment as done.Jul 12 2019, 9:07 PM
nridge added inline comments.
clang-tools-extra/docs/clangd/Features.rst
264

Right! I wouldn't delete any rows -- just maybe file (and link to) an LSP issue for any rows that don't already have proposals.

Revision Contents

PathSize
clang-tools-extra/
docs/
clangd/
2 lines

Diff 209408

clang-tools-extra/docs/clangd/Features.rst

Show First 20 Lines • Show All 255 Lines • ▼ Show 20 Lines
| Implement Method | Yes | No | | Implement Method | Yes | No |
+-------------------------------------+------------+----------+ +-------------------------------------+------------+----------+
| Gen. Getters/Setters | Yes | No | | Gen. Getters/Setters | Yes | No |
+-------------------------------------+------------+----------+ +-------------------------------------+------------+----------+
| Syntax and Semantic Coloring | No | No | | Syntax and Semantic Coloring | No | No |
+-------------------------------------+------------+----------+ +-------------------------------------+------------+----------+
| Call hierarchy | No | No | | Call hierarchy | No | No |
+-------------------------------------+------------+----------+ +-------------------------------------+------------+----------+
| Type hierarchy | No | No | | Type hierarchy | No | Yes |
nridgeAuthorUnsubmitted
Done
ReplyInline Actions

Should I perhaps change type hierarchy's entry in the LSP column from "No" to "Proposed"?

nridge: Should I perhaps change type hierarchy's entry in the LSP column from "No" to "Proposed"?
sammccallUnsubmitted
Not Done
ReplyInline Actions

I'm not sure what "no" means, if it doesn't mean "proposed".

Changing the "no" links to say "proposal" and link to it would be useful, I think.
(And we could delete any rows that don't have a proposal)

sammccall: I'm not sure what "no" means, if it doesn't mean "proposed". Changing the "no" links to say…
nridgeAuthorUnsubmitted
Done
ReplyInline Actions

Good idea -- I'll look at that in a separate commit.

nridge: Good idea -- I'll look at that in a separate commit.
malaperleUnsubmitted
Not Done
ReplyInline Actions

The rows that have "no" and don't have proposals meant that we wanted to make proposals for the LSP eventually in order to match other IDEs feature. Many didn't have proposals at the time.

malaperle: The rows that have "no" and don't have proposals meant that we wanted to make proposals for the…
nridgeAuthorUnsubmitted
Done
ReplyInline Actions

Right! I wouldn't delete any rows -- just maybe file (and link to) an LSP issue for any rows that don't already have proposals.

nridge: Right! I wouldn't delete any rows -- just maybe file (and link to) an LSP issue for any rows…
+-------------------------------------+------------+----------+ +-------------------------------------+------------+----------+
| Organize Includes | No | No | | Organize Includes | No | No |
+-------------------------------------+------------+----------+ +-------------------------------------+------------+----------+