This is an archive of the discontinued LLVM Phabricator instance.

[clangd] Mark type hierarchy as a supported feature in the docs
ClosedPublic

Authored by nridge on Jul 11 2019, 8:33 PM.

Diff Detail

Repository
rL LLVM

Event Timeline

nridge created this revision.Jul 11 2019, 8:33 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 11 2019, 8:33 PM
nridge marked an inline comment as done.Jul 11 2019, 8:34 PM
nridge added inline comments.
clang-tools-extra/docs/clangd/Features.rst
264 ↗(On Diff #209408)

Should I perhaps change type hierarchy's entry in the LSP column from "No" to "Proposed"?

sammccall accepted this revision.Jul 12 2019, 2:24 AM
sammccall added inline comments.
clang-tools-extra/docs/clangd/Features.rst
264 ↗(On Diff #209408)

I'm not sure what "no" means, if it doesn't mean "proposed".

Changing the "no" links to say "proposal" and link to it would be useful, I think.
(And we could delete any rows that don't have a proposal)

This revision is now accepted and ready to land.Jul 12 2019, 2:24 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptJul 12 2019, 8:25 PM
nridge marked an inline comment as done.Jul 12 2019, 8:26 PM
nridge added inline comments.
clang-tools-extra/docs/clangd/Features.rst
264 ↗(On Diff #209408)

Good idea -- I'll look at that in a separate commit.

malaperle added inline comments.
clang-tools-extra/docs/clangd/Features.rst
264 ↗(On Diff #209408)

The rows that have "no" and don't have proposals meant that we wanted to make proposals for the LSP eventually in order to match other IDEs feature. Many didn't have proposals at the time.

nridge marked an inline comment as done.Jul 12 2019, 9:07 PM
nridge added inline comments.
clang-tools-extra/docs/clangd/Features.rst
264 ↗(On Diff #209408)

Right! I wouldn't delete any rows -- just maybe file (and link to) an LSP issue for any rows that don't already have proposals.