This was causing large addresses to be emitted as negative numbers,
which rightfully caused crashes in binaryen.
Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
- Build Status
Buildable 34832 Build 34831: arc lint + arc unit
Event Timeline
lld/test/wasm/data-segments.ll | ||
---|---|---|
91 | It'd be better if we can get disassembly, but it seems to be not fully working yet | |
lld/wasm/Writer.cpp | ||
661 | Isn't [[ https://github.com/llvm/llvm-project/blob/c46d78d1b7a06aad11f8810279271224fc8466af/lld/wasm/OutputSegment.h#L39 | OutputSegment::startVA ]] already a uint32_t? |
lld/test/wasm/data-segments.ll | ||
---|---|---|
44 | How does this change test the logic change? Seems like 10000 isn't large enough to trigger the binaryen crash? |
How does this change test the logic change? Seems like 10000 isn't large enough to trigger the binaryen crash?