Page MenuHomePhabricator

[scudo][standalone] NFC corrections
ClosedPublic

Authored by cryptoad on Jul 11 2019, 9:15 AM.

Details

Summary

A few corrections:

  • rename TransferBatch::MaxCached to getMaxCached to conform with the style guide;
  • move getBlockBegin from Chunk:: to Allocator::: I believe it was a fallacy to have this be a Chunk method, as chunks' relationship to backend blocks are up to the frontend allocator. It makes more sense now, particularly with regard to the offset. Update the associated chunk test as the method isn't available there anymore;
  • add a forgotten \n to a log string;
  • for releaseToOs, instead of starting at 1, start at 0 and continue on BatchClassId: in the end it's identical but doesn't assume a particular class id for batches;
  • change a CHECK to a reportOutOfMemory: it's a clearer message

Diff Detail

Repository
rL LLVM

Event Timeline

cryptoad created this revision.Jul 11 2019, 9:15 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptJul 11 2019, 9:15 AM
Herald added subscribers: Restricted Project, delcypher. · View Herald Transcript
hctim accepted this revision.Jul 11 2019, 10:49 AM

LGTM.

This revision is now accepted and ready to land.Jul 11 2019, 10:49 AM
This revision was automatically updated to reflect the committed changes.