Page MenuHomePhabricator

rL365634 adds a unique_ptr<CompilationDatabase> in GobalCompilationDatabase.h:108 but CompilationDatabase is only forward declared. This makes the header not compile standalone, because unique_ptrs expect to have the full-definition of the...
ClosedPublic

Authored by saugustine on Jul 10 2019, 4:13 PM.

Details

Summary

...template argument.

Remove the forward declaration and include the appropriate header instead.

Diff Detail

Event Timeline

saugustine created this revision.Jul 10 2019, 4:13 PM

LGTM with one change -- thanks!

clang-tools-extra/clangd/GlobalCompilationDatabase.h
24

looks like clang/Tooling/CompilationDatabase.h has this, too; please delete

This revision is now accepted and ready to land.Jul 10 2019, 4:23 PM
saugustine marked an inline comment as done.

Remove other forward declaration also in the added header.

Committed as r365713.

sammccall closed this revision.Mon, Aug 12, 7:43 AM