This patch replaces the three almost identical "strip & accumulate"
implementations for constant pointer offsets with a single one,
combining the respective functionalities. The old interfaces are kept
for now.
Details
Details
Diff Detail
Diff Detail
- Repository
- rL LLVM
Event Timeline
llvm/include/llvm/IR/Value.h | ||
---|---|---|
565–569 ↗ | (On Diff #208987) | Thanks - the nullptr note is helpful. I don't know the rest of this code very well, so I'll let others review. |
Comment Actions
Not really familiar with this code, not sure i can review this, too.
If you state that you've run test-suite with this (and/or check-all of stage-2 clang), i could stamp though i guess.
Comment Actions
LGTM
llvm/lib/Analysis/InstructionSimplify.cpp | ||
---|---|---|
652 ↗ | (On Diff #208987) | This comment should be updated to say: When AllowNonInbounds is false, the results are usable for icmp ult/etc. folding. |