Page MenuHomePhabricator

ELF: Add support for R_AARCH64_ADR_PREL_PG_HI21_NC relocation.
ClosedPublic

Authored by pcc on Jul 9 2019, 5:08 PM.

Diff Detail

Repository
rL LLVM

Event Timeline

pcc created this revision.Jul 9 2019, 5:08 PM

Might be worth adding another test to aarch64-fpic-adr_prel_pg_hi21.s

pcc updated this revision to Diff 208866.Jul 9 2019, 7:35 PM
  • Address review comments
pcc added a comment.Jul 9 2019, 7:35 PM

Might be worth adding another test to aarch64-fpic-adr_prel_pg_hi21.s

Makes sense, done.

MaskRay accepted this revision.Jul 9 2019, 7:39 PM
This revision is now accepted and ready to land.Jul 9 2019, 7:39 PM

I've accepted D64455, looks good to me too.

ruiu accepted this revision.Jul 10 2019, 4:39 AM

LGTM

This revision was automatically updated to reflect the committed changes.