Match GNU readelf.
Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
- Build Status
Buildable 34648 Build 34647: arc lint + arc unit
Event Timeline
llvm/test/tools/llvm-readobj/macho-universal-x86_64.i386.test | ||
---|---|---|
151–152 | There was one empty line between } and File: , now there are two, due to the Writer.startLine() << "\n"; change. | |
llvm/tools/llvm-readobj/llvm-readobj.cpp | ||
604 | This will give us a trailing empty line. I think in a few other places, we do: if (not first) print a new line This pattern will not have a trailing empty line. I think these probably don't matter but it'd be great if we can be consistent in the future.. |
Thank you for capturing that. The added new line in the previous revision is for GNU output. I should have done what LLVM output did: add a prefixing new line.
llvm/test/tools/llvm-readobj/macho-universal-x86_64.i386.test | ||
---|---|---|
168–169 | Add a MULTIHEADER-ARCHIVE-EMPTY: and change this line to: |
llvm/test/tools/llvm-readobj/macho-universal-x86_64.i386.test | ||
---|---|---|
168–169 | For consistency other File: should receive the same treatment.. |
Looks good aside from a couple of minor points.
llvm/test/tools/llvm-readobj/archive.test | ||
---|---|---|
5–6 | Nit: I don't think it matters too much, but -D is a single-letter option, so would normally only have one dash before it. | |
8 | I think in this test particularly, you should check that there are the right number of new lines before and after "File: ..." using appropriate CHECK-NEXT/EMPTY markers. | |
llvm/test/tools/llvm-readobj/thin-archive-paths.test | ||
11–12 | nit --DARFILE -> -DARFILE |
Nit: I don't think it matters too much, but -D is a single-letter option, so would normally only have one dash before it.