Match GNU readelf.
|151 ↗||(On Diff #208479)|
There was one empty line between } and File: , now there are two, due to the Writer.startLine() << "\n"; change.
|604 ↗||(On Diff #208479)|
This will give us a trailing empty line. I think in a few other places, we do:
if (not first) print a new line
This pattern will not have a trailing empty line.
I think these probably don't matter but it'd be great if we can be consistent in the future..
|167 ↗||(On Diff #208572)|
Add a MULTIHEADER-ARCHIVE-EMPTY: and change this line to:
Looks good aside from a couple of minor points.
|5 ↗||(On Diff #208589)|
Nit: I don't think it matters too much, but -D is a single-letter option, so would normally only have one dash before it.
|8 ↗||(On Diff #208589)|
I think in this test particularly, you should check that there are the right number of new lines before and after "File: ..." using appropriate CHECK-NEXT/EMPTY markers.
|11 ↗||(On Diff #208589)|
nit --DARFILE -> -DARFILE