This is an archive of the discontinued LLVM Phabricator instance.

[clangd] Add HadErrors field into shards
ClosedPublic

Authored by kadircet on Jul 3 2019, 7:34 AM.

Event Timeline

kadircet created this revision.Jul 3 2019, 7:34 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 3 2019, 7:34 AM
kadircet updated this revision to Diff 207793.Jul 3 2019, 7:36 AM
  • Delete leftover header swap
sammccall accepted this revision.Jul 3 2019, 9:13 AM
sammccall added inline comments.
clang-tools-extra/clangd/Headers.h
65–73

nit: I'd tend to use a plain enum here to avoid the operator boilerplate, but up to you

This revision is now accepted and ready to land.Jul 3 2019, 9:13 AM
kadircet marked an inline comment as done.Jul 3 2019, 9:48 AM
kadircet added inline comments.
clang-tools-extra/clangd/Headers.h
65–73

I was more worried about incidental usages like:

IncludeGraphNode IGN;
if(IGN.IsTU) blabla;
kadircet updated this revision to Diff 207832.Jul 3 2019, 10:26 AM
  • Populate HadErrors in background index
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptJul 4 2019, 2:53 AM