This is an archive of the discontinued LLVM Phabricator instance.

Differential D64103

Teach ValueTracking that aarch64.irg result aliases its input.
ClosedPublic

Authored by eugenis on Jul 2 2019, 2:23 PM.

Details

Reviewers
javed.absar
olista01
ostannard
Commits
rG50dc28b5569a: Teach ValueTracking that aarch64.irg result aliases its input.
rL365079: Teach ValueTracking that aarch64.irg result aliases its input.

Diff Detail

Event Timeline

eugenis created this revision.Jul 2 2019, 2:23 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 2 2019, 2:23 PM
Herald added subscribers: hiraditya, kristof.beyls. · View Herald Transcript
Harbormaster completed remote builds in B34219: Diff 207628.Jul 2 2019, 2:23 PM
ostannard accepted this revision.Jul 3 2019, 2:17 AM
ostannard added a subscriber: ostannard.

LGTM

This revision is now accepted and ready to land.Jul 3 2019, 2:17 AM
Closed by commit rL365079: Teach ValueTracking that aarch64.irg result aliases its input. (authored by eugenis). · Explain WhyJul 3 2019, 1:19 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
llvm/
lib/
Analysis/
3 lines
test/
Analysis/
ValueTracking/
18 lines

Diff 207628

llvm/lib/Analysis/ValueTracking.cpp

Show First 20 Lines • Show All 3,691 Lines • ▼ Show 20 Linesconst Value *llvm::getArgumentAliasingToReturnedPointer(const CallBase *Call) {
if (isIntrinsicReturningPointerAliasingArgumentWithoutCapturing(Call)) if (isIntrinsicReturningPointerAliasingArgumentWithoutCapturing(Call))
return Call->getArgOperand(0); return Call->getArgOperand(0);
return nullptr; return nullptr;
} }
bool llvm::isIntrinsicReturningPointerAliasingArgumentWithoutCapturing( bool llvm::isIntrinsicReturningPointerAliasingArgumentWithoutCapturing(
const CallBase *Call) { const CallBase *Call) {
return Call->getIntrinsicID() == Intrinsic::launder_invariant_group || return Call->getIntrinsicID() == Intrinsic::launder_invariant_group ||
Call->getIntrinsicID() == Intrinsic::strip_invariant_group; Call->getIntrinsicID() == Intrinsic::strip_invariant_group ||
Call->getIntrinsicID() == Intrinsic::aarch64_irg;
} }
/// \p PN defines a loop-variant pointer to an object. Check if the /// \p PN defines a loop-variant pointer to an object. Check if the
/// previous iteration of the loop was referring to the same object as \p PN. /// previous iteration of the loop was referring to the same object as \p PN.
static bool isSameUnderlyingObjectInLoop(const PHINode *PN, static bool isSameUnderlyingObjectInLoop(const PHINode *PN,
const LoopInfo *LI) { const LoopInfo *LI) {
// Find the loop-defined value. // Find the loop-defined value.
Loop *L = LI->getLoopFor(PN->getParent()); Loop *L = LI->getLoopFor(PN->getParent());
▲ Show 20 Lines • Show All 2,022 Lines • Show Last 20 Lines

llvm/test/Analysis/ValueTracking/aarch64.irg.ll

  • This file was added.
; RUN: opt -S -instsimplify -instcombine < %s | FileCheck %s
; CHECK-LABEL: define void @checkNonnullIrg()
define void @checkNonnullIrg() {
; CHECK: %[[p:.*]] = call i8* @llvm.aarch64.irg(i8* nonnull
; CHECK: call void @use(i8* nonnull %[[p]])
entry:
%0 = alloca i8, align 16
%p = call i8* @llvm.aarch64.irg(i8* %0, i64 5)
call void @use(i8* %p)
ret void
}
declare i8* @llvm.aarch64.irg(i8*, i64)
declare void @use(i8*)