This is an archive of the discontinued LLVM Phabricator instance.

[RISCV][NFC] Split PseudoCALL pattern out from instruction
ClosedPublic

Authored by jrtc27 on Jul 1 2019, 7:56 AM.

Details

Summary

Since PseudoCALL defines AsmString, it can be generated from assembly,
and so code-gen patterns should be defined separately to be consistent
with the style of the RISCV backend. Other pseudo-instructions exist
that have code-gen patterns defined directly, but these instructions are
purely for code-gen and cannot be written in assembly.

Event Timeline

jrtc27 created this revision.Jul 1 2019, 7:56 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 1 2019, 7:57 AM
lenary accepted this revision.Jul 4 2019, 12:22 PM
lenary added a subscriber: lenary.

This looks good to me!

You've got quite a few useful patches that have been approved. Please may you request commit access so you can land them? https://www.llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access

This revision is now accepted and ready to land.Jul 4 2019, 12:22 PM
This revision was automatically updated to reflect the committed changes.