Page MenuHomePhabricator

[AMDGPU] LCSSA pass added in preISel.

Authored by alex-t on Jun 28 2019, 12:14 PM.



All the loops should come into ISel in LCSSA form to mark divergent
uniform values defined in the divergent loop and used outside

Diff Detail


Event Timeline

alex-t created this revision.Jun 28 2019, 12:14 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 28 2019, 12:14 PM
arsenm added inline comments.Jun 28 2019, 12:19 PM
381 ↗(On Diff #207128)

Maybe this should be under EXPENSIVE_CHECKs?

381 ↗(On Diff #207128)

The pass dependency in particular

nhaehnle accepted this revision.Jul 1 2019, 2:00 AM

Thanks for dealing with this. Matt's suggestion is reasonable to me, either way LGTM.

This revision is now accepted and ready to land.Jul 1 2019, 2:00 AM
alex-t updated this revision to Diff 207326.Jul 1 2019, 8:26 AM

isLCSSAForm check is under EXPENSIVE_CHECKS

This revision was automatically updated to reflect the committed changes.