This is an archive of the discontinued LLVM Phabricator instance.

AMDGPU/GFX10: fix scratch resource descriptor
ClosedPublic

Authored by nhaehnle on Jun 26 2019, 12:52 AM.

Details

Summary

The stride should depend on the wave size, not the hardware generation.

Also, the 32_FLOAT format is 0x16, not 16; though that shouldn't be
relevant.

Change-Id: I088f93bf6708974d085d1c50967f119061da6dc6

Diff Detail

Repository
rL LLVM

Event Timeline

nhaehnle created this revision.Jun 26 2019, 12:52 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 26 2019, 12:52 AM
nhaehnle updated this revision to Diff 207052.Jun 28 2019, 6:28 AM

Add a test case

nhaehnle updated this revision to Diff 207055.Jun 28 2019, 6:37 AM

Properly test based on wavefront size

arsenm accepted this revision.Jun 28 2019, 6:43 AM

LGTM

This revision is now accepted and ready to land.Jun 28 2019, 6:43 AM
This revision was automatically updated to reflect the committed changes.