[NFC] Make some ObjectFormatType switches covering

[hubert.reinterpretcast]

Summary

This patch removes the default case from some switches on llvm::Triple::ObjectFormatType, and cases for the missing enumerators are then added.

For UnknownObjectFormat, the action (llvm_unreachable) for the default case is kept.

For the other unhandled cases, report_fatal_error is used instead.

[hubert.reinterpretcast]

Ping.

[sfertile]

LGTM.

cfe/trunk/lib/CodeGen/CGObjCMac.cpp

return llvm::ConstantInt::get(
     Offset);
 }
 
 /* *** Private Interface *** */
 
 std::string CGObjCCommonMac::GetSectionName(StringRef Section,
                                             StringRef MachOAttributes) {
   switch (CGM.getTriple().getObjectFormat()) {
-  default:
+  case llvm::Triple::UnknownObjectFormat:
     llvm_unreachable("unexpected object file format");
   case llvm::Triple::MachO: {
     if (MachOAttributes.empty())
       return ("__DATA," + Section).str();
     return ("__DATA," + Section + "," + MachOAttributes).str();
   }
   case llvm::Triple::ELF:
     assert(Section.substr(0, 2) == "__" &&
            "expected the name to begin with __");
     return Section.substr(2).str();
   case llvm::Triple::COFF:
     assert(Section.substr(0, 2) == "__" &&
            "expected the name to begin with __");
     return ("." + Section.substr(2) + "$B").str();
+  case llvm::Triple::Wasm:
+  case llvm::Triple::XCOFF:
+    llvm::report_fatal_error(
+        "Objective-C support is unimplemented for object file format.");
   }
 }
 
 /// EmitImageInfo - Emit the image info marker used to encode some module
 /// level information.
 ///
 /// See: <rdr://4810609&4810587&4810587>
 /// struct IMAGE_INFO {

llvm/trunk/include/llvm/Support/TargetRegistry.h

MCStreamer *createMCObjectStreamer(const Triple &T, MCContext &Ctx,
                                      std::unique_ptr<MCAsmBackend> &&TAB,
                                      std::unique_ptr<MCObjectWriter> &&OW,
                                      std::unique_ptr<MCCodeEmitter> &&Emitter,
                                      const MCSubtargetInfo &STI, bool RelaxAll,
                                      bool IncrementalLinkerCompatible,
                                      bool DWARFMustBeAtTheEnd) const {
     MCStreamer *S;
     switch (T.getObjectFormat()) {
-    default:
+    case Triple::UnknownObjectFormat:
       llvm_unreachable("Unknown object format");
     case Triple::COFF:
       assert(T.isOSWindows() && "only Windows COFF is supported");
       S = COFFStreamerCtorFn(Ctx, std::move(TAB), std::move(OW),
                              std::move(Emitter), RelaxAll,
                              IncrementalLinkerCompatible);
       break;
     case Triple::MachO:
MCStreamer *createMCObjectStreamer(const Triple &T, MCContext &Ctx,
     case Triple::Wasm:
       if (WasmStreamerCtorFn)
         S = WasmStreamerCtorFn(T, Ctx, std::move(TAB), std::move(OW),
                                std::move(Emitter), RelaxAll);
       else
         S = createWasmStreamer(Ctx, std::move(TAB), std::move(OW),
                                std::move(Emitter), RelaxAll);
       break;
+    case Triple::XCOFF:
+      report_fatal_error("XCOFF MCObjectStreamer not implemented yet.");
     }
     if (ObjectTargetStreamerCtorFn)
       ObjectTargetStreamerCtorFn(*S, STI);
     return S;
   }
 
   MCStreamer *createAsmStreamer(MCContext &Ctx,
                                 std::unique_ptr<formatted_raw_ostream> OS,