Page MenuHomePhabricator

[clangd] Cleanup the duplicated getTokenRange.
ClosedPublic

Authored by hokein on Mon, Jun 24, 7:04 AM.

Details

Summary

Also lift it to SourceCode.h, so that it can be used in other places
(semantic code highlighting).

Diff Detail

Repository
rL LLVM

Event Timeline

hokein created this revision.Mon, Jun 24, 7:04 AM
kadircet accepted this revision.Mon, Jun 24, 8:45 AM
kadircet added inline comments.
clang-tools-extra/clangd/XRefs.cpp
926 ↗(On Diff #206208)

nit: move declaration into if body?

This revision is now accepted and ready to land.Mon, Jun 24, 8:45 AM
hokein updated this revision to Diff 206380.Tue, Jun 25, 1:00 AM
hokein marked an inline comment as done.

Address review comments.

This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptTue, Jun 25, 1:06 AM