Page MenuHomePhabricator

[MIPS GlobalISel] Select floating point to integer conversions
ClosedPublic

Authored by Petar.Avramovic on Jun 19 2019, 4:42 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

Herald added a project: Restricted Project. · View Herald TranscriptJun 19 2019, 4:42 AM
atanasyan accepted this revision.Jun 19 2019, 7:50 AM

LGTM with a couple nits.

lib/Target/Mips/MipsInstructionSelector.cpp
371 ↗(On Diff #205550)

Maybe use the same terms as in the LegalizerHelper: FromSize and ToSize? Just for uniformity.

373 ↗(On Diff #205550)

In the MipsRegisterBankInfo::getInstrMapping the same checking made by a couple of assert. Let's either split this check or merge the check in the MipsRegisterBankInfo::getInstrMapping. As well for uniformity

This revision is now accepted and ready to land.Jun 19 2019, 7:50 AM

Addressed review comments.

Petar.Avramovic marked 2 inline comments as done.Jun 20 2019, 1:40 AM
This revision was automatically updated to reflect the committed changes.