This is an archive of the discontinued LLVM Phabricator instance.

Differential D63483

[clangd] Detect C++ language based on well-known file path in vscode extension
ClosedPublic

Authored by hokein on Jun 18 2019, 4:30 AM.

Details

Reviewers
sammccall
Commits
rG40fdd7a643b5: [clangd] Detect C++ language based on well-known file path in vscode extension
rCTE363662: [clangd] Detect C++ language based on well-known file path in vscode extension
rL363662: [clangd] Detect C++ language based on well-known file path in vscode extension
Summary

Matching the "C++" pattern on the first line of the file doesn't cover
all cases, MSVC C++ headers doesn't have such pattern. This patch
introduce a new heuristic to detect language based on the file path.

MSVC C++ standard headers are in the directory like
"c:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools\VC\Tools\MSVC\14.15.26726\include"

Diff Detail

Repository
rL LLVM

Event Timeline

hokein created this revision.Jun 18 2019, 4:30 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 18 2019, 4:30 AM
Herald added subscribers: kadircet, arphaman, jkorous and 2 others. · View Herald Transcript
Harbormaster completed remote builds in B33547: Diff 205300.Jun 18 2019, 4:30 AM
sammccall accepted this revision.Jun 18 2019, 4:34 AM
This revision is now accepted and ready to land.Jun 18 2019, 4:34 AM
Closed by commit rL363662: [clangd] Detect C++ language based on well-known file path in vscode extension (authored by hokein). · Explain WhyJun 18 2019, 4:50 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptJun 18 2019, 4:50 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript

Revision Contents

PathSize
clang-tools-extra/
trunk/
clangd/
clients/
clangd-vscode/
4 lines

Diff 205306

clang-tools-extra/trunk/clangd/clients/clangd-vscode/package.json

Show First 20 Lines • Show All 46 Lines • ▼ Show 20 Lines
}, },
"repository": { "repository": {
"type": "svn", "type": "svn",
"url": "http://llvm.org/svn/llvm-project/clang-tools-extra/trunk/clangd/clients/clangd-vscode/" "url": "http://llvm.org/svn/llvm-project/clang-tools-extra/trunk/clangd/clients/clangd-vscode/"
}, },
"contributes": { "contributes": {
"languages": [{ "languages": [{
"id": "cpp", "id": "cpp",
"filenamePatterns": [
"**/include/c++/**",
"**/MSVC/*/include/**"
],
"firstLine": "^\/[/*].*-\\*-\\s*C\\+\\+\\s*-\\*-.*" "firstLine": "^\/[/*].*-\\*-\\s*C\\+\\+\\s*-\\*-.*"
}], }],
"configuration": { "configuration": {
"type": "object", "type": "object",
"title": "clangd configuration", "title": "clangd configuration",
"properties": { "properties": {
"clangd.path": { "clangd.path": {
"type": "string", "type": "string",
▲ Show 20 Lines • Show All 42 Lines • Show Last 20 Lines