This is an archive of the discontinued LLVM Phabricator instance.

[OpenMP] Strengthen regression tests for task allocation under nowait depend clauses NFC
ClosedPublic

Authored by gtbercea on Jun 17 2019, 12:52 PM.

Details

Summary

This patch strengthens the tests introduced in D63009 by:

  • adding new test for default device ID.
  • modifying existing tests to pass device ID local variable to the task allocation function.

Diff Detail

Event Timeline

gtbercea created this revision.Jun 17 2019, 12:52 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 17 2019, 12:52 PM
Hahnfeld added inline comments.Jun 17 2019, 1:03 PM
test/OpenMP/target_constant_device_codegen.cpp
3–5

I think you only need these 3 lines (although not really sure about the PCH).

14–34

Please only leave structs and variables that are really used and needed (in particular only one depend)

38

Can you please also add another target region with a real clause + constant, ie device(1)?

gtbercea updated this revision to Diff 205186.Jun 17 2019, 2:18 PM
  • Fix test.
gtbercea marked 3 inline comments as done.Jun 17 2019, 2:18 PM
This revision is now accepted and ready to land.Jun 19 2019, 6:42 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptJun 19 2019, 7:24 AM