This is an archive of the discontinued LLVM Phabricator instance.

[AMDGPU] gfx1010 dpp16 and dpp8
ClosedPublic

Authored by rampitec on Jun 12 2019, 7:37 AM.

Diff Detail

Event Timeline

rampitec created this revision.Jun 12 2019, 7:37 AM
arsenm added inline comments.Jun 12 2019, 8:42 AM
include/llvm/IR/IntrinsicsAMDGPU.td
1457

Needs immarg, and to be marked as a source of divergence

arsenm added inline comments.Jun 12 2019, 8:48 AM
include/llvm/IR/IntrinsicsAMDGPU.td
1457

I think it's a source of divergence? It's missing from the existing DPP intrinsics, but that might be a bug?

rampitec marked an inline comment as done.Jun 12 2019, 8:48 AM
rampitec added inline comments.
include/llvm/IR/IntrinsicsAMDGPU.td
1457

I agree. But in a separate change.

rampitec marked an inline comment as done.
rampitec added inline comments.
include/llvm/IR/IntrinsicsAMDGPU.td
1457
rampitec marked 2 inline comments as done.Jun 12 2019, 9:51 AM
kzhuravl accepted this revision.Jun 12 2019, 10:47 AM

LGTM

include/llvm/IR/IntrinsicsAMDGPU.td
1457

Is D63216 expecting to cause any merge conflicts downstream?

This revision is now accepted and ready to land.Jun 12 2019, 10:47 AM
rampitec marked an inline comment as done.Jun 12 2019, 10:51 AM
rampitec added inline comments.
include/llvm/IR/IntrinsicsAMDGPU.td
1457

Yes. Therefor I am going to wait the merge of this change, and only then submit D63216. That way it will avoid conflicts.

kzhuravl added inline comments.Jun 12 2019, 10:52 AM
include/llvm/IR/IntrinsicsAMDGPU.td
1457

Thanks!

This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptJun 12 2019, 11:01 AM