Page MenuHomePhabricator

[clangd] Return TextEdits from ClangdServer::applyTweak
ClosedPublic

Authored by ilya-biryukov on Jun 11 2019, 7:31 AM.

Details

Summary

Instead of tooling::Replacements. So that embedders do not need to store
the contents of the file.

This also aligns better with ClangdServer::rename.

Diff Detail

Repository
rL LLVM

Event Timeline

ilya-biryukov created this revision.Jun 11 2019, 7:31 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 11 2019, 7:31 AM
ilya-biryukov edited the summary of this revision. (Show Details)Jun 11 2019, 7:35 AM

@hokein just realized you might be a better reviewer, since this makes applyTweak aligned with rename. And you implemented rename in the first place

hokein accepted this revision.Jun 12 2019, 4:49 AM

looks good.

This revision is now accepted and ready to land.Jun 12 2019, 4:49 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptJun 12 2019, 5:00 AM