This is an archive of the discontinued LLVM Phabricator instance.

Differential D62920

Included `test/support/test_workarounds.h` which actually defines `TEST_WORKAROUND_CONSTEXPR_IMPLIES_NOEXCEPT` for variant tests.
ClosedPublic

Authored by mpark on Jun 5 2019, 10:46 AM.

Details

Reviewers
EricWF
ldionne
Commits
rG8f500a6f9ca0: [libcxx][test] Include test_workarounds.h where needed
rCXX362660: [libcxx][test] Include test_workarounds.h where needed
rL362660: [libcxx][test] Include test_workarounds.h where needed
Summary

Found this through a failure in mpark/variant CI job: https://travis-ci.org/mpark/variant/jobs/541538917.

Diff Detail

Event Timeline

mpark created this revision.Jun 5 2019, 10:46 AM
Herald added subscribers: libcxx-commits, arphaman, ldionne, christof. · View Herald TranscriptJun 5 2019, 10:46 AM
mpark edited the summary of this revision. (Show Details)Jun 5 2019, 10:46 AM
Harbormaster completed remote builds in B32944: Diff 203203.Jun 5 2019, 10:46 AM
ldionne accepted this revision.Jun 5 2019, 2:29 PM
This revision is now accepted and ready to land.Jun 5 2019, 2:29 PM
Herald added a subscriber: dexonsmith. · View Herald TranscriptJun 5 2019, 2:29 PM
Closed by commit rL362660: [libcxx][test] Include test_workarounds.h where needed (authored by ldionne). · Explain WhyJun 5 2019, 2:51 PM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptJun 5 2019, 2:51 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript

Revision Contents

PathSize
test/
std/
utilities/
variant/
variant.get/
1 line
1 line

Diff 203203

test/std/utilities/variant/variant.get/get_index.pass.cpp

Show All 21 Lines
// template <size_t I, class... Types> // template <size_t I, class... Types>
// constexpr variant_alternative_t<I, variant<Types...>> const& get(const // constexpr variant_alternative_t<I, variant<Types...>> const& get(const
// variant<Types...>& v); // variant<Types...>& v);
// template <size_t I, class... Types> // template <size_t I, class... Types>
// constexpr variant_alternative_t<I, variant<Types...>> const&& get(const // constexpr variant_alternative_t<I, variant<Types...>> const&& get(const
// variant<Types...>&& v); // variant<Types...>&& v);
#include "test_macros.h" #include "test_macros.h"
#include "test_workarounds.h"
#include "variant_test_helpers.hpp" #include "variant_test_helpers.hpp"
#include <cassert> #include <cassert>
#include <type_traits> #include <type_traits>
#include <utility> #include <utility>
#include <variant> #include <variant>
void test_const_lvalue_get() { void test_const_lvalue_get() {
{ {
▲ Show 20 Lines • Show All 257 Lines • Show Last 20 Lines

test/std/utilities/variant/variant.get/get_type.pass.cpp

Show All 15 Lines
// template <class T, class... Types> constexpr T& get(variant<Types...>& v); // template <class T, class... Types> constexpr T& get(variant<Types...>& v);
// template <class T, class... Types> constexpr T&& get(variant<Types...>&& v); // template <class T, class... Types> constexpr T&& get(variant<Types...>&& v);
// template <class T, class... Types> constexpr const T& get(const // template <class T, class... Types> constexpr const T& get(const
// variant<Types...>& v); // variant<Types...>& v);
// template <class T, class... Types> constexpr const T&& get(const // template <class T, class... Types> constexpr const T&& get(const
// variant<Types...>&& v); // variant<Types...>&& v);
#include "test_macros.h" #include "test_macros.h"
#include "test_workarounds.h"
#include "variant_test_helpers.hpp" #include "variant_test_helpers.hpp"
#include <cassert> #include <cassert>
#include <type_traits> #include <type_traits>
#include <utility> #include <utility>
#include <variant> #include <variant>
void test_const_lvalue_get() { void test_const_lvalue_get() {
{ {
▲ Show 20 Lines • Show All 263 Lines • Show Last 20 Lines