Page MenuHomePhabricator

[FormatEntity] Ignore ASCII escape sequences when colors are disabled.
ClosedPublic

Authored by JDevlieghere on May 30 2019, 7:03 PM.

Diff Detail

Repository
rLLDB LLDB

Event Timeline

JDevlieghere created this revision.May 30 2019, 7:03 PM
Herald added a project: Restricted Project. ยท View Herald TranscriptMay 30 2019, 7:03 PM

Seems good to me.

lldb/lit/Settings/TestFrameFormatColor.test
12

I don't see any escape code here, I assume phabricator is just not showing them? ๐Ÿ˜›

JDevlieghere marked an inline comment as done.May 30 2019, 7:46 PM
JDevlieghere added inline comments.
lldb/lit/Settings/TestFrameFormatColor.test
12

Yup!

teemperor accepted this revision.May 31 2019, 1:13 AM

LGTM, thanks!

This revision is now accepted and ready to land.May 31 2019, 1:13 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. ยท View Herald TranscriptMay 31 2019, 9:25 AM
Herald added a subscriber: llvm-commits. ยท View Herald Transcript
clayborg added inline comments.
lldb/trunk/include/lldb/Core/FormatEntity.h
44 โ†—(On Diff #202452)

InsertString is used for more than just escape codes so it is now not named correctly. For a variable formatter string like "(${var.x}, ${var.y})", the "(" is a string, and ", " and ")" are InsertString objects. Any constant string that is part of a formatter. Can you change the name back?