This is an archive of the discontinued LLVM Phabricator instance.

Differential D62712

[CMake][Fuchsia] Use libc++ ABI v2 on Darwin as well
ClosedPublic

Authored by phosek on May 30 2019, 6:10 PM.

Details

Reviewers
mcgrathr
jakehehrlich
juliehockett
EricWF
Commits
rGa35c50c9a4d1: [CMake][Fuchsia] Use libc++ ABI v2 on Darwin as well
rL362181: [CMake][Fuchsia] Use libc++ ABI v2 on Darwin as well
rC362181: [CMake][Fuchsia] Use libc++ ABI v2 on Darwin as well
Summary

Since we share headers between host and target builds, we need to use
the same version for both.

Diff Detail

Repository
rC Clang

Event Timeline

phosek created this revision.May 30 2019, 6:10 PM
Herald added a reviewer: EricWF. · View Herald TranscriptMay 30 2019, 6:10 PM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: cfe-commits, mgorny. · View Herald Transcript
mcgrathr accepted this revision.May 30 2019, 6:12 PM

lgtm

This revision is now accepted and ready to land.May 30 2019, 6:12 PM
Closed by commit rL362181: [CMake][Fuchsia] Use libc++ ABI v2 on Darwin as well (authored by phosek). · Explain WhyMay 30 2019, 6:15 PM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptMay 30 2019, 6:15 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript

Revision Contents

PathSize
clang/
cmake/
caches/
1 line

Diff 202345

clang/cmake/caches/Fuchsia-stage2.cmake

Show First 20 Lines • Show All 43 Lines • ▼ Show 20 Linesif(APPLE)
set(LIBCXXABI_ENABLE_SHARED OFF CACHE BOOL "") set(LIBCXXABI_ENABLE_SHARED OFF CACHE BOOL "")
set(LIBCXXABI_ENABLE_STATIC_UNWINDER ON CACHE BOOL "") set(LIBCXXABI_ENABLE_STATIC_UNWINDER ON CACHE BOOL "")
set(LIBCXXABI_INSTALL_LIBRARY OFF CACHE BOOL "") set(LIBCXXABI_INSTALL_LIBRARY OFF CACHE BOOL "")
set(LIBCXXABI_USE_COMPILER_RT ON CACHE BOOL "") set(LIBCXXABI_USE_COMPILER_RT ON CACHE BOOL "")
set(LIBCXXABI_USE_LLVM_UNWINDER ON CACHE BOOL "") set(LIBCXXABI_USE_LLVM_UNWINDER ON CACHE BOOL "")
set(LIBCXX_USE_COMPILER_RT ON CACHE BOOL "") set(LIBCXX_USE_COMPILER_RT ON CACHE BOOL "")
set(LIBCXX_ENABLE_SHARED OFF CACHE BOOL "") set(LIBCXX_ENABLE_SHARED OFF CACHE BOOL "")
set(LIBCXX_ENABLE_STATIC_ABI_LIBRARY ON CACHE BOOL "") set(LIBCXX_ENABLE_STATIC_ABI_LIBRARY ON CACHE BOOL "")
set(LIBCXX_ABI_VERSION 2 CACHE STRING "")
endif() endif()
foreach(target aarch64-unknown-linux-gnu;armv7-unknown-linux-gnueabihf;i386-unknown-linux-gnu;x86_64-unknown-linux-gnu) foreach(target aarch64-unknown-linux-gnu;armv7-unknown-linux-gnueabihf;i386-unknown-linux-gnu;x86_64-unknown-linux-gnu)
if(LINUX_${target}_SYSROOT) if(LINUX_${target}_SYSROOT)
# Set the per-target builtins options. # Set the per-target builtins options.
list(APPEND BUILTIN_TARGETS "${target}") list(APPEND BUILTIN_TARGETS "${target}")
set(BUILTINS_${target}_CMAKE_SYSTEM_NAME Linux CACHE STRING "") set(BUILTINS_${target}_CMAKE_SYSTEM_NAME Linux CACHE STRING "")
set(BUILTINS_${target}_CMAKE_BUILD_TYPE Release CACHE STRING "") set(BUILTINS_${target}_CMAKE_BUILD_TYPE Release CACHE STRING "")
▲ Show 20 Lines • Show All 149 Lines • Show Last 20 Lines