This is an archive of the discontinued LLVM Phabricator instance.

[llvm-objcopy] Fixed discontinuity in error messages
AbandonedPublic

Authored by abrachet on May 30 2019, 1:06 AM.

Details

Summary

[llvm-objcopy] Fixed discontinuity in error messages

Event Timeline

abrachet created this revision.May 30 2019, 1:06 AM

This was mistakenly committed last night. There are two different commits in here. How do I delete this? Sorry about that

abrachet abandoned this revision.May 30 2019, 8:44 AM

This was mistakenly committed last night. There are two different commits in here. How do I delete this? Sorry about that

Hi @abrachet,

Strictly speaking, all Phabricator shows is a diff versus some base version that it was created from, as shown by e.g. svn diff. As a result, you don't need to "delete" a commit, and can just update the diff. However, if this was inadvertently created for review, then abandoning the change as you have done is completely fine.