This is an archive of the discontinued LLVM Phabricator instance.

[ARM] ARMExpandPseudoInsts: add debug messages
ClosedPublic

Authored by SjoerdMeijer on May 23 2019, 2:55 AM.

Details

Summary

This pass wasn't printing any messages at all, which I find really inconvenient while debugging/tracing things. It now dumps the before and after of expanded instructions. It doesn't do this yet for all instructions, but this is a good start I guess.

Diff Detail

Event Timeline

SjoerdMeijer created this revision.May 23 2019, 2:55 AM

I like the Expanding/To, but I think dumping the whole function is a bit excessive. That's what -print-after-all is for really.

SjoerdMeijer edited the summary of this revision. (Show Details)

Thanks, agreed! I've removed printing the whole function.

t.p.northover accepted this revision.May 24 2019, 1:16 AM

Thanks. LGTM.

This revision is now accepted and ready to land.May 24 2019, 1:16 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptMay 24 2019, 1:22 AM