This is an archive of the discontinued LLVM Phabricator instance.

Differential D62277

[llvm-objdump] Emit error if start address equal to stop address
AbandonedPublic

Authored by anushabasana on May 22 2019, 5:32 PM.

Details

Reviewers
smeenai
jhenderson
alexander-shaposhnikov
Summary

Fixes PR41862

Diff Detail

Event Timeline

anushabasana created this revision.May 22 2019, 5:32 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 22 2019, 5:32 PM
Herald added subscribers: llvm-commits, rupprecht. · View Herald Transcript
Harbormaster completed remote builds in B32345: Diff 200847.May 22 2019, 5:33 PM
anushabasana abandoned this revision.May 22 2019, 5:34 PM

Diff already exists: D61969. I was just getting familiar with llvm.

alexander-shaposhnikov added a reviewer: alexander-shaposhnikov.May 23 2019, 3:46 AM

Revision Contents

PathSize
llvm/
test/
tools/
llvm-objdump/
X86/
2 lines
tools/
llvm-objdump/
2 lines

Diff 200847

llvm/test/tools/llvm-objdump/X86/start-stop-address.test

Show All 25 Lines
// CROSSDATA: Disassembly of section .anothertext: // CROSSDATA: Disassembly of section .anothertext:
// CROSSDATA: main: // CROSSDATA: main:
// CROSSDATA: 40: 48 83 c4 20 addq $32, %rsp // CROSSDATA: 40: 48 83 c4 20 addq $32, %rsp
// CROSSDATA: 44: 5d popq %rbp // CROSSDATA: 44: 5d popq %rbp
// CROSSDATA-DAG: somedata: // CROSSDATA-DAG: somedata:
// CROSSDATA-NEXT: 45: 74 65 te // CROSSDATA-NEXT: 45: 74 65 te
// RUN: not llvm-objdump -d %t.out --start-address=0x18 --stop-address=0x18 2>&1 | FileCheck %s --check-prefix ERR
// ERR: Start address should be less than stop address

llvm/tools/llvm-objdump/llvm-objdump.cpp

Show First 20 Lines • Show All 1,397 Lines • ▼ Show 20 Lines#endif
Index += Size; Index += Size;
} }
} }
} }
} }
static void disassembleObject(const ObjectFile *Obj, bool InlineRelocs) { static void disassembleObject(const ObjectFile *Obj, bool InlineRelocs) {
if (StartAddress > StopAddress) if (StartAddress >= StopAddress)
error("Start address should be less than stop address"); error("Start address should be less than stop address");
const Target *TheTarget = getTarget(Obj); const Target *TheTarget = getTarget(Obj);
// Package up features to be passed to target/subtarget // Package up features to be passed to target/subtarget
SubtargetFeatures Features = Obj->getFeatures(); SubtargetFeatures Features = Obj->getFeatures();
if (!MAttrs.empty()) if (!MAttrs.empty())
for (unsigned I = 0; I != MAttrs.size(); ++I) for (unsigned I = 0; I != MAttrs.size(); ++I)
▲ Show 20 Lines • Show All 676 Lines • Show Last 20 Lines