[libcxx] change dylib- XFAILs to UNSUPPORTED

[ldionne]

I'd like to better understand what problem this is solving:

• What platform are you testing on?
• How did you configure CMake?
• How do you run lit?

[bcain]

In D61915#1502008, @ldionne wrote:

I'd like to better understand what problem this is solving:

• What platform are you testing on?
• How did you configure CMake?
• How do you run lit?

Here's what I think are relevant commits that introduced this behavior:

• https://reviews.llvm.org/rCXX356616
• https://reviews.llvm.org/rCXX356640

The problem I get are XPASS on the following tests:

Unexpected Passing Tests (7):
    libc++ :: std/input.output/file.streams/fstreams/filebuf.members/open_path.pass.cpp
    libc++ :: std/input.output/file.streams/fstreams/fstream.cons/path.pass.cpp
    libc++ :: std/input.output/file.streams/fstreams/fstream.members/open_path.pass.cpp
    libc++ :: std/input.output/file.streams/fstreams/ifstream.cons/path.pass.cpp
    libc++ :: std/input.output/file.streams/fstreams/ifstream.members/open_path.pass.cpp
    libc++ :: std/input.output/file.streams/fstreams/ofstream.cons/path.pass.cpp
    libc++ :: std/input.output/file.streams/fstreams/ofstream.members/open_path.pass.cpp

I was able to reproduce this problem with ToT and x86_64 linux if I set LIBCXX_ENABLE_FILESYSTEM to "False" or "OFF" with just ninja check-cxx. AFAICT diffusion/phabricator won't let me upload arbitrary files like the full unabridged logs so I'll find another place to put them.

AFAIK the idiom for XFAIL is intended for a WIP feature or a defect that can't or shouldn't be fixed (yet) and if this test starts passing it requires some investigation. I am assuming that dylib-has-no-* is just indicating that a relevant feature for this test is missing or disabled on this target, and as such I would suggest that it doesn't make sense to execute the test at all if the feature is missing. And if it passes for some reason in this configuration it's not interesting and worth investigation. Maybe the test no longer depends on the feature, but is that worthy of failing the test suite? So that's why I have applied this change to all similar tests, not just the ones that I see the XPASS on.

But maybe that's not the case? Maybe these tests don't really depend on this feature? Or maybe r356640 should have created a new feature instead of wiring ENABLE_FILESYSTEM into the dylib-has-no-filesystem one?

[mclow.lists]

In D61915#1502132, @bcain wrote:

AFAIK the idiom for XFAIL is intended for a WIP feature or a defect that can't or shouldn't be fixed (yet) and if this test starts passing it requires some investigation. I am assuming that dylib-has-no-* is just indicating that a relevant feature for this test is missing or disabled on this target, and as such I would suggest that it doesn't make sense to execute the test at all if the feature is missing. And if it passes for some reason in this configuration it's not interesting and worth investigation. Maybe the test no longer depends on the feature, but is that worthy of failing the test suite? So that's why I have applied this change to all similar tests, not just the ones that I see the XPASS on.

But maybe that's not the case? Maybe these tests don't really depend on this feature? Or maybe r356640 should have created a new feature instead of wiring ENABLE_FILESYSTEM into the dylib-has-no-filesystem one?

That's not my thinking.

• XFAIL is "expected to fail" (for whatever reason)
• UNSUPPORTED is "this test is not worth running"

(I'm going to comment on just the variant/optional/ any tests here, because I think they're straightforward).
They're marked as XFAIL when the dylib doesn't have the appropriate exception classes - and they should fail.
They also should fail if they are built with exceptions disabled - because the exceptions will never get thrown. This behavior should be confirmed.

If they pass, then something very strange is going on, and should be investigated.
Either the test is not testing what we want, or the dylib is not getting built in the manner that we expect.

[bcain]

In D61915#1503179, @mclow.lists wrote:

In D61915#1502132, @bcain wrote:

...

(I'm going to comment on just the variant/optional/ any tests here, because I think they're straightforward).
They're marked as XFAIL when the dylib doesn't have the appropriate exception classes - and they should fail.
They also should fail if they are built with exceptions disabled - because the exceptions will never get thrown. This behavior should be confirmed.

Fair enough.

So I took a minute to try and understand the XPASS and I think that the filesystem header installation isn't guarded by LIBCXX_ENABLE_FILESYSTEM -- only the sources.

Maybe the presence of the filesystem header is enough to get some of these tests to pass. So maybe I should go ahead and change this patch to do that instead?

[bcain]

In D61915#1503235, @bcain wrote:

...

Maybe the presence of the filesystem header is enough to get some of these tests to pass. So maybe I should go ahead and change this patch to do that instead?

"do that" -- change the include/CMakeLists.txt to make the filesystem header installation conditional on LIBCXX_ENABLE_FILESYSTEM, I mean.

[ldionne]

In D61915#1503235, @bcain wrote:

Maybe the presence of the filesystem header is enough to get some of these tests to pass. [...]

Yes, I think this is exactly what's happening, and this is what I wanted to understand. I think the best solution would be for LIBCXX_ENABLE_FILESYSTEM to actually control whether filesystem is enabled in the library, however this includes:

• whether we build support for filesystem in the dylib (that's the only thing we already do)
• whether the <filesystem> header is provided
• whether we provide operations like std::ifstream::open() on std::filesystem::path & friends

I think if we had that, then we could rename the lit feature from dylib-has-no-filesystem to just has-no-filesystem, and that feature would be enabled whenever:

• we are testing back-deployment to a platform that doesn't have dylib support for filesystem (and has availability markup that makes it invalid to use stuff like std::ifstream::open(std::filesystem::path))
• we are testing libc++ trunk without filesystem support (your use case)

Is this something you'd be willing to investigate? I think having a good example of how to disable complete features from the library would be useful for other things as well, so this is something we need to do at some point. For example, our story for things like LIBCXX_ENABLE_STDIN and LIBCXX_ENABLE_STDOUT is similarly broken.

[bcain]

In D61915#1503525, @ldionne wrote:

In D61915#1503235, @bcain wrote:

Maybe the presence of the filesystem header is enough to get some of these tests to pass. [...]

Yes, I think this is exactly what's happening, and this is what I wanted to understand. I think the best solution would be for LIBCXX_ENABLE_FILESYSTEM to actually control whether filesystem is enabled in the library, however this includes:

• whether we build support for filesystem in the dylib (that's the only thing we already do)
• whether the <filesystem> header is provided
• whether we provide operations like std::ifstream::open() on std::filesystem::path & friends

I think if we had that, then we could rename the lit feature from dylib-has-no-filesystem to just has-no-filesystem, and that feature would be enabled whenever:

• we are testing back-deployment to a platform that doesn't have dylib support for filesystem (and has availability markup that makes it invalid to use stuff like std::ifstream::open(std::filesystem::path))
• we are testing libc++ trunk without filesystem support (your use case)

Is this something you'd be willing to investigate? I think having a good example of how to disable complete features from the library would be useful for other things as well, so this is something we need to do at some point. For example, our story for things like LIBCXX_ENABLE_STDIN and LIBCXX_ENABLE_STDOUT is similarly broken.

Sure, I will take a look. I tried whipping up a quick patch but I wasn't able to clean up all of the references from std::*fstream (though I think I figured out chrono).

Also, I based that quick patch on the handling for LIBCXX_ENABLE_THREADS / _LIBCPP_HAS_NO_THREADS. In that case, <thread> is still provided but hits an #error when included. Does that suffice for what you think <filesystem> should do or should we really suppress the installation?

[ldionne]

In D61915#1503571, @bcain wrote:

In D61915#1503525, @ldionne wrote:

In D61915#1503235, @bcain wrote:

Maybe the presence of the filesystem header is enough to get some of these tests to pass. [...]

Yes, I think this is exactly what's happening, and this is what I wanted to understand. I think the best solution would be for LIBCXX_ENABLE_FILESYSTEM to actually control whether filesystem is enabled in the library, however this includes:

• whether we build support for filesystem in the dylib (that's the only thing we already do)
• whether the <filesystem> header is provided
• whether we provide operations like std::ifstream::open() on std::filesystem::path & friends

I think if we had that, then we could rename the lit feature from dylib-has-no-filesystem to just has-no-filesystem, and that feature would be enabled whenever:

• we are testing back-deployment to a platform that doesn't have dylib support for filesystem (and has availability markup that makes it invalid to use stuff like std::ifstream::open(std::filesystem::path))
• we are testing libc++ trunk without filesystem support (your use case)

Is this something you'd be willing to investigate? I think having a good example of how to disable complete features from the library would be useful for other things as well, so this is something we need to do at some point. For example, our story for things like LIBCXX_ENABLE_STDIN and LIBCXX_ENABLE_STDOUT is similarly broken.

Sure, I will take a look. I tried whipping up a quick patch but I wasn't able to clean up all of the references from std::*fstream (though I think I figured out chrono).

Also, I based that quick patch on the handling for LIBCXX_ENABLE_THREADS / _LIBCPP_HAS_NO_THREADS. In that case, <thread> is still provided but hits an #error when included. Does that suffice for what you think <filesystem> should do or should we really suppress the installation?

I think an #error is OK for now, but in the long term we'll want to make this friendlier to __has_include.

[ldionne]

Is this still relevant? If not, can we close this to clean up the review queue?

[ldionne]

Abandoning to clear up the review queue since I don't think that's relevant anymore. If it still is, please re-open!

libcxx/test/std/input.output/file.streams/fstreams/filebuf.members/open_path.pass.cpp

 //===----------------------------------------------------------------------===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 //
 //===----------------------------------------------------------------------===//
 
 // UNSUPPORTED: c++98, c++03, c++11, c++14
-// XFAIL: dylib-has-no-filesystem
+// UNSUPPORTED: dylib-has-no-filesystem
 
 // <fstream>
 
 // basic_filebuf<charT,traits>* open(const filesystem::path& p, ios_base::openmode mode);
 
 #include <fstream>
 #include <filesystem>
 #include <cassert>

libcxx/test/std/input.output/file.streams/fstreams/fstream.cons/path.pass.cpp

 //===----------------------------------------------------------------------===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 //
 //===----------------------------------------------------------------------===//
 
 // UNSUPPORTED: c++98, c++03, c++11, c++14
-// XFAIL: dylib-has-no-filesystem
+// UNSUPPORTED: dylib-has-no-filesystem
 
 // <fstream>
 
 // plate <class charT, class traits = char_traits<charT> >
 // class basic_fstream
 
 // explicit basic_fstream(const filesystem::path& s,
 //     ios_base::openmode mode = ios_base::in|ios_base::out);

libcxx/test/std/input.output/file.streams/fstreams/fstream.members/open_path.pass.cpp

 //===----------------------------------------------------------------------===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 //
 //===----------------------------------------------------------------------===//
 
 // UNSUPPORTED: c++98, c++03, c++11, c++14
-// XFAIL: dylib-has-no-filesystem
+// UNSUPPORTED: dylib-has-no-filesystem
 
 // <fstream>
 
 // plate <class charT, class traits = char_traits<charT> >
 // class basic_fstream
 
 // void open(const filesystem::path& s, ios_base::openmode mode = ios_base::in|ios_base::out);
 

libcxx/test/std/input.output/file.streams/fstreams/ifstream.cons/path.pass.cpp

 //===----------------------------------------------------------------------===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 //
 //===----------------------------------------------------------------------===//
 
 // UNSUPPORTED: c++98, c++03, c++11, c++14
-// XFAIL: dylib-has-no-filesystem
+// UNSUPPORTED: dylib-has-no-filesystem
 
 // <fstream>
 
 // template <class charT, class traits = char_traits<charT> >
 // class basic_ifstream
 
 // explicit basic_ifstream(const filesystem::path& s,
 //     ios_base::openmode mode = ios_base::in);

libcxx/test/std/input.output/file.streams/fstreams/ifstream.members/open_path.pass.cpp

 //===----------------------------------------------------------------------===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 //
 //===----------------------------------------------------------------------===//
 
 // UNSUPPORTED: c++98, c++03, c++11, c++14
-// XFAIL: dylib-has-no-filesystem
+// UNSUPPORTED: dylib-has-no-filesystem
 
 // <fstream>
 
 // template <class charT, class traits = char_traits<charT> >
 // class basic_ifstream
 
 // void open(const filesystem::path& s, ios_base::openmode mode = ios_base::in);
 

libcxx/test/std/input.output/file.streams/fstreams/ofstream.cons/path.pass.cpp

 //===----------------------------------------------------------------------===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 //
 //===----------------------------------------------------------------------===//
 
 // UNSUPPORTED: c++98, c++03, c++11, c++14
-// XFAIL: dylib-has-no-filesystem
+// UNSUPPORTED: dylib-has-no-filesystem
 
 // <fstream>
 
 // plate <class charT, class traits = char_traits<charT> >
 // class basic_ofstream
 
 // explicit basic_ofstream(const filesystem::path& s, ios_base::openmode mode = ios_base::out);
 

libcxx/test/std/input.output/file.streams/fstreams/ofstream.members/open_path.pass.cpp

 //===----------------------------------------------------------------------===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 //
 //===----------------------------------------------------------------------===//
 
 // UNSUPPORTED: c++98, c++03, c++11, c++14
-// XFAIL: dylib-has-no-filesystem
+// UNSUPPORTED: dylib-has-no-filesystem
 
 // <fstream>
 
 // plate <class charT, class traits = char_traits<charT> >
 // class basic_ofstream
 
 // void open(const filesystem::path& s, ios_base::openmode mode = ios_base::out);
 

libcxx/test/std/thread/thread.mutex/thread.lock/thread.lock.shared/thread.lock.shared.cons/default.pass.cpp

 //===----------------------------------------------------------------------===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 //
 //===----------------------------------------------------------------------===//
 //
 // UNSUPPORTED: libcpp-has-no-threads
 // UNSUPPORTED: c++98, c++03, c++11
-// XFAIL: dylib-has-no-shared_mutex
+// UNSUPPORTED: dylib-has-no-shared_mutex
 
 // <shared_mutex>
 
 // template <class Mutex> class shared_lock;
 
 // shared_lock();
 
 #include <shared_mutex>

libcxx/test/std/thread/thread.mutex/thread.lock/thread.lock.shared/thread.lock.shared.cons/move_assign.pass.cpp

 //===----------------------------------------------------------------------===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 //
 //===----------------------------------------------------------------------===//
 //
 // UNSUPPORTED: libcpp-has-no-threads
 // UNSUPPORTED: c++98, c++03, c++11
-// XFAIL: dylib-has-no-shared_mutex
+// UNSUPPORTED: dylib-has-no-shared_mutex
 
 // <shared_mutex>
 
 // template <class Mutex> class shared_lock;
 
 // shared_lock& operator=(shared_lock&& u);
 
 #include <shared_mutex>

libcxx/test/std/thread/thread.mutex/thread.lock/thread.lock.shared/thread.lock.shared.cons/move_ctor.pass.cpp

 //===----------------------------------------------------------------------===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 //
 //===----------------------------------------------------------------------===//
 //
 // UNSUPPORTED: libcpp-has-no-threads
 // UNSUPPORTED: c++98, c++03, c++11
-// XFAIL: dylib-has-no-shared_mutex
+// UNSUPPORTED: dylib-has-no-shared_mutex
 
 // <shared_mutex>
 
 // template <class Mutex> class shared_lock;
 
 // shared_lock(shared_lock&& u);
 
 #include <shared_mutex>

libcxx/test/std/thread/thread.mutex/thread.lock/thread.lock.shared/thread.lock.shared.cons/mutex.pass.cpp

 //===----------------------------------------------------------------------===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 //
 //===----------------------------------------------------------------------===//
 //
 // UNSUPPORTED: libcpp-has-no-threads
 // UNSUPPORTED: c++98, c++03, c++11
-// XFAIL: dylib-has-no-shared_mutex
+// UNSUPPORTED: dylib-has-no-shared_mutex
 
 // FLAKY_TEST.
 
 // <shared_mutex>
 
 // template <class Mutex> class shared_lock;
 
 // explicit shared_lock(mutex_type& m);

libcxx/test/std/thread/thread.mutex/thread.lock/thread.lock.shared/thread.lock.shared.cons/mutex_adopt_lock.pass.cpp

 //===----------------------------------------------------------------------===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 //
 //===----------------------------------------------------------------------===//
 //
 // UNSUPPORTED: libcpp-has-no-threads
 // UNSUPPORTED: c++98, c++03, c++11
-// XFAIL: dylib-has-no-shared_mutex
+// UNSUPPORTED: dylib-has-no-shared_mutex
 
 // <shared_mutex>
 
 // template <class Mutex> class shared_lock;
 
 // shared_lock(mutex_type& m, adopt_lock_t);
 
 #include <shared_mutex>

libcxx/test/std/thread/thread.mutex/thread.lock/thread.lock.shared/thread.lock.shared.cons/mutex_defer_lock.pass.cpp

 //===----------------------------------------------------------------------===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 //
 //===----------------------------------------------------------------------===//
 //
 // UNSUPPORTED: libcpp-has-no-threads
 // UNSUPPORTED: c++98, c++03, c++11
-// XFAIL: dylib-has-no-shared_mutex
+// UNSUPPORTED: dylib-has-no-shared_mutex
 
 // <shared_mutex>
 
 // template <class Mutex> class shared_lock;
 
 // shared_lock(mutex_type& m, defer_lock_t);
 
 #include <shared_mutex>

libcxx/test/std/thread/thread.mutex/thread.lock/thread.lock.shared/thread.lock.shared.cons/mutex_duration.pass.cpp

 //===----------------------------------------------------------------------===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 //
 //===----------------------------------------------------------------------===//
 //
 // UNSUPPORTED: libcpp-has-no-threads
 // UNSUPPORTED: c++98, c++03, c++11
-// XFAIL: dylib-has-no-shared_mutex
+// UNSUPPORTED: dylib-has-no-shared_mutex
 
 // FLAKY_TEST.
 
 // <shared_mutex>
 
 // class timed_mutex;
 
 // template <class Rep, class Period>

libcxx/test/std/thread/thread.mutex/thread.lock/thread.lock.shared/thread.lock.shared.cons/mutex_time_point.pass.cpp

 //===----------------------------------------------------------------------===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 //
 //===----------------------------------------------------------------------===//
 //
 // UNSUPPORTED: libcpp-has-no-threads
 // UNSUPPORTED: c++98, c++03, c++11
-// XFAIL: dylib-has-no-shared_mutex
+// UNSUPPORTED: dylib-has-no-shared_mutex
 
 // FLAKY_TEST.
 
 // <shared_mutex>
 
 // class shared_timed_mutex;
 
 // template <class Clock, class Duration>

libcxx/test/std/thread/thread.mutex/thread.lock/thread.lock.shared/thread.lock.shared.cons/mutex_try_to_lock.pass.cpp

 //===----------------------------------------------------------------------===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 //
 //===----------------------------------------------------------------------===//
 //
 // UNSUPPORTED: libcpp-has-no-threads
 // UNSUPPORTED: c++98, c++03, c++11
-// XFAIL: dylib-has-no-shared_mutex
+// UNSUPPORTED: dylib-has-no-shared_mutex
 
 // FLAKY_TEST.
 
 // <shared_mutex>
 
 // template <class Mutex> class shared_lock;
 
 // shared_lock(mutex_type& m, try_to_lock_t);

libcxx/test/std/thread/thread.mutex/thread.lock/thread.lock.shared/thread.lock.shared.locking/lock.pass.cpp

 //===----------------------------------------------------------------------===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 //
 //===----------------------------------------------------------------------===//
 //
 // UNSUPPORTED: libcpp-has-no-threads
 // UNSUPPORTED: c++98, c++03, c++11
-// XFAIL: dylib-has-no-shared_mutex
+// UNSUPPORTED: dylib-has-no-shared_mutex
 
 // FLAKY_TEST.
 
 // <shared_mutex>
 
 // template <class Mutex> class shared_lock;
 
 // void lock();

libcxx/test/std/thread/thread.mutex/thread.lock/thread.lock.shared/thread.lock.shared.obs/mutex.pass.cpp

 //===----------------------------------------------------------------------===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 //
 //===----------------------------------------------------------------------===//
 //
 // UNSUPPORTED: libcpp-has-no-threads
 // UNSUPPORTED: c++98, c++03, c++11
-// XFAIL: dylib-has-no-shared_mutex
+// UNSUPPORTED: dylib-has-no-shared_mutex
 
 // <shared_mutex>
 
 // template <class Mutex> class shared_lock;
 
 // mutex_type *mutex() const noexcept;
 
 #include <shared_mutex>

libcxx/test/std/thread/thread.mutex/thread.lock/thread.lock.shared/thread.lock.shared.obs/op_bool.pass.cpp

 //===----------------------------------------------------------------------===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 //
 //===----------------------------------------------------------------------===//
 //
 // UNSUPPORTED: libcpp-has-no-threads
 // UNSUPPORTED: c++98, c++03, c++11
-// XFAIL: dylib-has-no-shared_mutex
+// UNSUPPORTED: dylib-has-no-shared_mutex
 
 // <shared_mutex>
 
 // template <class Mutex> class shared_lock;
 
 // explicit operator bool() const noexcept;
 
 #include <shared_mutex>

libcxx/test/std/thread/thread.mutex/thread.lock/thread.lock.shared/thread.lock.shared.obs/owns_lock.pass.cpp

 //===----------------------------------------------------------------------===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 //
 //===----------------------------------------------------------------------===//
 //
 // UNSUPPORTED: libcpp-has-no-threads
 // UNSUPPORTED: c++98, c++03, c++11
-// XFAIL: dylib-has-no-shared_mutex
+// UNSUPPORTED: dylib-has-no-shared_mutex
 
 // <shared_mutex>
 
 // template <class Mutex> class shared_lock;
 
 // bool owns_lock() const noexcept;
 
 #include <shared_mutex>

libcxx/test/std/utilities/any/any.class/any.assign/copy.pass.cpp

 //===----------------------------------------------------------------------===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 //
 //===----------------------------------------------------------------------===//
 
 // UNSUPPORTED: c++98, c++03, c++11, c++14
 
-// XFAIL: dylib-has-no-bad_any_cast && !libcpp-no-exceptions
+// UNSUPPORTED: dylib-has-no-bad_any_cast && !libcpp-no-exceptions
 
 // <any>
 
 // any& operator=(any const &);
 
 // Test copy assignment
 
 #include <any>

libcxx/test/std/utilities/any/any.class/any.assign/move.pass.cpp

 //===----------------------------------------------------------------------===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 //
 //===----------------------------------------------------------------------===//
 
 // UNSUPPORTED: c++98, c++03, c++11, c++14
 
-// XFAIL: dylib-has-no-bad_any_cast && !libcpp-no-exceptions
+// UNSUPPORTED: dylib-has-no-bad_any_cast && !libcpp-no-exceptions
 
 // <any>
 
 // any& operator=(any &&);
 
 // Test move assignment.
 
 #include <any>

libcxx/test/std/utilities/any/any.class/any.assign/value.pass.cpp

 //===----------------------------------------------------------------------===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 //
 //===----------------------------------------------------------------------===//
 
 // UNSUPPORTED: c++98, c++03, c++11, c++14
 
-// XFAIL: dylib-has-no-bad_any_cast && !libcpp-no-exceptions
+// UNSUPPORTED: dylib-has-no-bad_any_cast && !libcpp-no-exceptions
 
 // <any>
 
 // template <class ValueType>
 // any& operator=(ValueType&&);
 
 // Test value copy and move assignment.
 

libcxx/test/std/utilities/any/any.class/any.cons/copy.pass.cpp

 //===----------------------------------------------------------------------===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 //
 //===----------------------------------------------------------------------===//
 
 // UNSUPPORTED: c++98, c++03, c++11, c++14
 
-// XFAIL: dylib-has-no-bad_any_cast && !libcpp-no-exceptions
+// UNSUPPORTED: dylib-has-no-bad_any_cast && !libcpp-no-exceptions
 
 // <any>
 
 // any(any const &);
 
 #include <any>
 #include <cassert>
 

libcxx/test/std/utilities/any/any.class/any.cons/in_place_type.pass.cpp

 //===----------------------------------------------------------------------===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 //
 //===----------------------------------------------------------------------===//
 
 // UNSUPPORTED: c++98, c++03, c++11, c++14
 
-// XFAIL: dylib-has-no-bad_any_cast && !libcpp-no-exceptions
+// UNSUPPORTED: dylib-has-no-bad_any_cast && !libcpp-no-exceptions
 
 // <any>
 
 // template <class T, class ...Args> any(in_place_type_t<T>, Args&&...);
 // template <class T, class U, class ...Args>
 // any(in_place_type_t<T>, initializer_list<U>, Args&&...);
 
 // Test construction from a value.

libcxx/test/std/utilities/any/any.class/any.cons/move.pass.cpp

 //===----------------------------------------------------------------------===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 //
 //===----------------------------------------------------------------------===//
 
 // UNSUPPORTED: c++98, c++03, c++11, c++14
 
-// XFAIL: dylib-has-no-bad_any_cast && !libcpp-no-exceptions
+// UNSUPPORTED: dylib-has-no-bad_any_cast && !libcpp-no-exceptions
 
 // <any>
 
 // any(any &&) noexcept;
 
 #include <any>
 #include <utility>
 #include <type_traits>

libcxx/test/std/utilities/any/any.class/any.cons/value.pass.cpp

 //===----------------------------------------------------------------------===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 //
 //===----------------------------------------------------------------------===//
 
 // UNSUPPORTED: c++98, c++03, c++11, c++14
 
-// XFAIL: dylib-has-no-bad_any_cast && !libcpp-no-exceptions
+// UNSUPPORTED: dylib-has-no-bad_any_cast && !libcpp-no-exceptions
 
 // <any>
 
 // template <class Value> any(Value &&)
 
 // Test construction from a value.
 // Concerns:
 // ---------

libcxx/test/std/utilities/any/any.class/any.modifiers/emplace.pass.cpp

 //===----------------------------------------------------------------------===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 //
 //===----------------------------------------------------------------------===//
 
 // UNSUPPORTED: c++98, c++03, c++11, c++14
 
-// XFAIL: dylib-has-no-bad_any_cast && !libcpp-no-exceptions
+// UNSUPPORTED: dylib-has-no-bad_any_cast && !libcpp-no-exceptions
 
 // <any>
 
 // template <class T, class ...Args> T& emplace(Args&&...);
 // template <class T, class U, class ...Args>
 // T& emplace(initializer_list<U>, Args&&...);
 
 #include <any>

libcxx/test/std/utilities/any/any.class/any.modifiers/reset.pass.cpp

 //===----------------------------------------------------------------------===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 //
 //===----------------------------------------------------------------------===//
 
 // UNSUPPORTED: c++98, c++03, c++11, c++14
 
-// XFAIL: dylib-has-no-bad_any_cast && !libcpp-no-exceptions
+// UNSUPPORTED: dylib-has-no-bad_any_cast && !libcpp-no-exceptions
 
 // <any>
 
 // any::reset() noexcept
 
 #include <any>
 #include <cassert>
 

libcxx/test/std/utilities/any/any.class/any.modifiers/swap.pass.cpp

 //===----------------------------------------------------------------------===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 //
 //===----------------------------------------------------------------------===//
 
 // UNSUPPORTED: c++98, c++03, c++11, c++14
 
-// XFAIL: dylib-has-no-bad_any_cast && !libcpp-no-exceptions
+// UNSUPPORTED: dylib-has-no-bad_any_cast && !libcpp-no-exceptions
 
 // <any>
 
 // any::swap(any &) noexcept
 
 // Test swap(large, small) and swap(small, large)
 
 #include <any>

libcxx/test/std/utilities/any/any.nonmembers/any.cast/any_cast_pointer.pass.cpp

 //===----------------------------------------------------------------------===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 //
 //===----------------------------------------------------------------------===//
 
 // UNSUPPORTED: c++98, c++03, c++11, c++14
 
-// XFAIL: dylib-has-no-bad_any_cast && !libcpp-no-exceptions
+// UNSUPPORTED: dylib-has-no-bad_any_cast && !libcpp-no-exceptions
 
 // <any>
 
 // template <class ValueType>
 // ValueType const* any_cast(any const *) noexcept;
 //
 // template <class ValueType>
 // ValueType * any_cast(any *) noexcept;

libcxx/test/std/utilities/any/any.nonmembers/any.cast/any_cast_reference.pass.cpp

 //===----------------------------------------------------------------------===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 //
 //===----------------------------------------------------------------------===//
 
 // UNSUPPORTED: c++98, c++03, c++11, c++14
 
-// XFAIL: dylib-has-no-bad_any_cast && !libcpp-no-exceptions
+// UNSUPPORTED: dylib-has-no-bad_any_cast && !libcpp-no-exceptions
 
 // <any>
 
 // template <class ValueType>
 // ValueType const any_cast(any const&);
 //
 // template <class ValueType>
 // ValueType any_cast(any &);

libcxx/test/std/utilities/any/any.nonmembers/make_any.pass.cpp

 //===----------------------------------------------------------------------===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 //
 //===----------------------------------------------------------------------===//
 
 // UNSUPPORTED: c++98, c++03, c++11, c++14
 
-// XFAIL: dylib-has-no-bad_any_cast && !libcpp-no-exceptions
+// UNSUPPORTED: dylib-has-no-bad_any_cast && !libcpp-no-exceptions
 
 // <any>
 
 // template <class T, class ...Args> any make_any(Args&&...);
 // template <class T, class U, class ...Args>
 // any make_any(initializer_list<U>, Args&&...);
 
 #include <any>

libcxx/test/std/utilities/any/any.nonmembers/swap.pass.cpp

 //===----------------------------------------------------------------------===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 //
 //===----------------------------------------------------------------------===//
 
 // UNSUPPORTED: c++98, c++03, c++11, c++14
 
-// XFAIL: dylib-has-no-bad_any_cast && !libcpp-no-exceptions
+// UNSUPPORTED: dylib-has-no-bad_any_cast && !libcpp-no-exceptions
 
 // <any>
 
 // void swap(any &, any &) noexcept
 
 // swap(...) just wraps any::swap(...). That function is tested elsewhere.
 
 #include <any>

libcxx/test/std/utilities/optional/optional.bad_optional_access/default.pass.cpp

 //===----------------------------------------------------------------------===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 //
 //===----------------------------------------------------------------------===//
 
 // UNSUPPORTED: c++98, c++03, c++11, c++14
 
-// XFAIL: dylib-has-no-bad_optional_access
+// UNSUPPORTED: dylib-has-no-bad_optional_access
 
 // <optional>
 
 // class bad_optional_access is default constructible
 
 #include <optional>
 #include <type_traits>
 
 int main(int, char**)
 {
     using std::bad_optional_access;
     bad_optional_access ex;
 
   return 0;
 }

libcxx/test/std/utilities/optional/optional.bad_optional_access/derive.pass.cpp

 //===----------------------------------------------------------------------===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 //
 //===----------------------------------------------------------------------===//
 
 // UNSUPPORTED: c++98, c++03, c++11, c++14
-// XFAIL: dylib-has-no-bad_optional_access
+// UNSUPPORTED: dylib-has-no-bad_optional_access
 
 // <optional>
 
 // class bad_optional_access : public exception
 
 #include <optional>
 #include <type_traits>
 

libcxx/test/std/utilities/optional/optional.object/optional.object.ctor/U.pass.cpp

 //===----------------------------------------------------------------------===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 //
 //===----------------------------------------------------------------------===//
 //
 // UNSUPPORTED: c++98, c++03, c++11, c++14
 
-// XFAIL: dylib-has-no-bad_optional_access && !libcpp-no-exceptions
+// UNSUPPORTED: dylib-has-no-bad_optional_access && !libcpp-no-exceptions
 
 // <optional>
 
 // template <class U>
 //   constexpr EXPLICIT optional(U&& u);
 
 #include <optional>
 #include <type_traits>

libcxx/test/std/utilities/optional/optional.object/optional.object.ctor/const_T.pass.cpp

 //===----------------------------------------------------------------------===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 //
 //===----------------------------------------------------------------------===//
 //
 // UNSUPPORTED: c++98, c++03, c++11, c++14
 
-// XFAIL: dylib-has-no-bad_optional_access && !libcpp-no-exceptions
+// UNSUPPORTED: dylib-has-no-bad_optional_access && !libcpp-no-exceptions
 
 // <optional>
 
 // constexpr optional(const T& v);
 
 #include <optional>
 #include <type_traits>
 #include <cassert>

libcxx/test/std/utilities/optional/optional.object/optional.object.ctor/move.pass.cpp

 //===----------------------------------------------------------------------===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 //
 //===----------------------------------------------------------------------===//
 
 // UNSUPPORTED: c++98, c++03, c++11, c++14
 
-// XFAIL: dylib-has-no-bad_optional_access && !libcpp-no-exceptions
+// UNSUPPORTED: dylib-has-no-bad_optional_access && !libcpp-no-exceptions
 
 // <optional>
 
 // constexpr optional(optional<T>&& rhs);
 
 #include <optional>
 #include <type_traits>
 #include <cassert>

libcxx/test/std/utilities/optional/optional.object/optional.object.ctor/rvalue_T.pass.cpp

 //===----------------------------------------------------------------------===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 //
 //===----------------------------------------------------------------------===//
 //
 // UNSUPPORTED: c++98, c++03, c++11, c++14
 
-// XFAIL: dylib-has-no-bad_optional_access && !libcpp-no-exceptions
+// UNSUPPORTED: dylib-has-no-bad_optional_access && !libcpp-no-exceptions
 
 // <optional>
 
 // constexpr optional(T&& v);
 
 #include <optional>
 #include <type_traits>
 #include <cassert>

libcxx/test/std/utilities/optional/optional.object/optional.object.observe/value.pass.cpp

 //===----------------------------------------------------------------------===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 //
 //===----------------------------------------------------------------------===//
 
 // UNSUPPORTED: c++98, c++03, c++11, c++14
 
-// XFAIL: dylib-has-no-bad_optional_access && !libcpp-no-exceptions
+// UNSUPPORTED: dylib-has-no-bad_optional_access && !libcpp-no-exceptions
 
 // <optional>
 
 // constexpr T& optional<T>::value() &;
 
 #include <optional>
 #include <type_traits>
 #include <cassert>

libcxx/test/std/utilities/optional/optional.object/optional.object.observe/value_const.pass.cpp

 //===----------------------------------------------------------------------===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 //
 //===----------------------------------------------------------------------===//
 
 // UNSUPPORTED: c++98, c++03, c++11, c++14
 
-// XFAIL: dylib-has-no-bad_optional_access && !libcpp-no-exceptions
+// UNSUPPORTED: dylib-has-no-bad_optional_access && !libcpp-no-exceptions
 
 // <optional>
 
 // constexpr const T& optional<T>::value() const &;
 
 #include <optional>
 #include <type_traits>
 #include <cassert>

libcxx/test/std/utilities/optional/optional.object/optional.object.observe/value_const_rvalue.pass.cpp

 //===----------------------------------------------------------------------===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 //
 //===----------------------------------------------------------------------===//
 
 // UNSUPPORTED: c++98, c++03, c++11, c++14
 
-// XFAIL: dylib-has-no-bad_optional_access && !libcpp-no-exceptions
+// UNSUPPORTED: dylib-has-no-bad_optional_access && !libcpp-no-exceptions
 
 // <optional>
 
 // constexpr const T& optional<T>::value() const &&;
 
 #include <optional>
 #include <type_traits>
 #include <cassert>

libcxx/test/std/utilities/optional/optional.object/optional.object.observe/value_rvalue.pass.cpp

 //===----------------------------------------------------------------------===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 //
 //===----------------------------------------------------------------------===//
 
 // UNSUPPORTED: c++98, c++03, c++11, c++14
 // <optional>
 
-// XFAIL: dylib-has-no-bad_optional_access && !libcpp-no-exceptions
+// UNSUPPORTED: dylib-has-no-bad_optional_access && !libcpp-no-exceptions
 
 // constexpr T& optional<T>::value() &&;
 
 #include <optional>
 #include <type_traits>
 #include <cassert>
 
 #include "test_macros.h"

libcxx/test/std/utilities/optional/optional.specalg/make_optional.pass.cpp

 //===----------------------------------------------------------------------===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 //
 //===----------------------------------------------------------------------===//
 
 // UNSUPPORTED: c++98, c++03, c++11, c++14
-// XFAIL: dylib-has-no-bad_optional_access && !libcpp-no-exceptions
+// UNSUPPORTED: dylib-has-no-bad_optional_access && !libcpp-no-exceptions
 
 // <optional>
 //
 // template <class T>
 //   constexpr optional<decay_t<T>> make_optional(T&& v);
 
 #include <optional>
 #include <string>

libcxx/test/std/utilities/time/time.clock/time.clock.file/now.pass.cpp

 //===----------------------------------------------------------------------===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 //
 //===----------------------------------------------------------------------===//
 
 // UNSUPPORTED: c++98, c++03, c++11, c++14, c++17
-// XFAIL: dylib-has-no-filesystem
+// UNSUPPORTED: dylib-has-no-filesystem
 
 // <chrono>
 
 // file_clock
 
 // static time_point now() noexcept;
 
 #include <chrono>

libcxx/test/std/utilities/variant/variant.bad_variant_access/bad_variant_access.pass.cpp

 // -*- C++ -*-
 //===----------------------------------------------------------------------===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 //
 //===----------------------------------------------------------------------===//
 
 // UNSUPPORTED: c++98, c++03, c++11, c++14
 
-// XFAIL: dylib-has-no-bad_variant_access
-
+// UNSUPPORTED: dylib-has-no-bad_variant_access
 
 // <variant>
 
 /*
 
  class bad_variant_access : public exception {
 public:
   bad_variant_access() noexcept;

libcxx/test/std/utilities/variant/variant.get/get_index.pass.cpp

 // -*- C++ -*-
 //===----------------------------------------------------------------------===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 //
 //===----------------------------------------------------------------------===//
 
 // UNSUPPORTED: c++98, c++03, c++11, c++14
 
-// XFAIL: dylib-has-no-bad_variant_access && !libcpp-no-exceptions
+// UNSUPPORTED: dylib-has-no-bad_variant_access && !libcpp-no-exceptions
 
 // <variant>
 
 // template <size_t I, class... Types>
 //   constexpr variant_alternative_t<I, variant<Types...>>&
 //   get(variant<Types...>& v);
 // template <size_t I, class... Types>
 //   constexpr variant_alternative_t<I, variant<Types...>>&&

libcxx/test/std/utilities/variant/variant.get/get_type.pass.cpp

 // -*- C++ -*-
 //===----------------------------------------------------------------------===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 //
 //===----------------------------------------------------------------------===//
 
 // UNSUPPORTED: c++98, c++03, c++11, c++14
 
-// XFAIL: dylib-has-no-bad_variant_access && !libcpp-no-exceptions
+// UNSUPPORTED: dylib-has-no-bad_variant_access && !libcpp-no-exceptions
 
 // <variant>
 
 // template <class T, class... Types> constexpr T& get(variant<Types...>& v);
 // template <class T, class... Types> constexpr T&& get(variant<Types...>&& v);
 // template <class T, class... Types> constexpr const T& get(const
 // variant<Types...>& v);
 // template <class T, class... Types> constexpr const T&& get(const

libcxx/test/std/utilities/variant/variant.variant/variant.assign/T.pass.cpp

 // -*- C++ -*-
 //===----------------------------------------------------------------------===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 //
 //===----------------------------------------------------------------------===//
 
 // UNSUPPORTED: c++98, c++03, c++11, c++14
 
-// XFAIL: dylib-has-no-bad_variant_access && !libcpp-no-exceptions
+// UNSUPPORTED: dylib-has-no-bad_variant_access && !libcpp-no-exceptions
 
 // <variant>
 
 // template <class ...Types> class variant;
 
 // template <class T>
 // variant& operator=(T&&) noexcept(see below);
 

libcxx/test/std/utilities/variant/variant.variant/variant.assign/copy.pass.cpp

 // -*- C++ -*-
 //===----------------------------------------------------------------------===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 //
 //===----------------------------------------------------------------------===//
 
 // UNSUPPORTED: c++98, c++03, c++11, c++14
 
 // The following compilers don't generate constexpr special members correctly.
 // XFAIL: clang-3.5, clang-3.6, clang-3.7, clang-3.8
 // XFAIL: apple-clang-6, apple-clang-7, apple-clang-8.0
 
-// XFAIL: dylib-has-no-bad_variant_access && !libcpp-no-exceptions
+// UNSUPPORTED: dylib-has-no-bad_variant_access && !libcpp-no-exceptions
 
 // <variant>
 
 // template <class ...Types> class variant;
 
 // variant& operator=(variant const&); // constexpr in C++20
 
 #include <cassert>

libcxx/test/std/utilities/variant/variant.variant/variant.assign/move.pass.cpp

 // -*- C++ -*-
 //===----------------------------------------------------------------------===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 //
 //===----------------------------------------------------------------------===//
 
 // UNSUPPORTED: c++98, c++03, c++11, c++14
 
 // The following compilers don't generate constexpr special members correctly.
 // XFAIL: clang-3.5, clang-3.6, clang-3.7, clang-3.8
 // XFAIL: apple-clang-6, apple-clang-7, apple-clang-8.0
 
-// XFAIL: dylib-has-no-bad_variant_access && !libcpp-no-exceptions
-
+// UNSUPPORTED: dylib-has-no-bad_variant_access && !libcpp-no-exceptions
 
 // <variant>
 
 // template <class ...Types> class variant;
 
 // variant& operator=(variant&&) noexcept(see below); // constexpr in C++20
 
 #include <cassert>

libcxx/test/std/utilities/variant/variant.variant/variant.ctor/T.pass.cpp

 // -*- C++ -*-
 //===----------------------------------------------------------------------===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 //
 //===----------------------------------------------------------------------===//
 
 // UNSUPPORTED: c++98, c++03, c++11, c++14
-// XFAIL: dylib-has-no-bad_variant_access && !libcpp-no-exceptions
+// UNSUPPORTED: dylib-has-no-bad_variant_access && !libcpp-no-exceptions
 
 // <variant>
 
 // template <class ...Types> class variant;
 
 // template <class T> constexpr variant(T&&) noexcept(see below);
 
 #include <cassert>

libcxx/test/std/utilities/variant/variant.variant/variant.ctor/copy.pass.cpp

 // -*- C++ -*-
 //===----------------------------------------------------------------------===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 //
 //===----------------------------------------------------------------------===//
 
 // UNSUPPORTED: c++98, c++03, c++11, c++14
 
-// XFAIL: dylib-has-no-bad_variant_access && !libcpp-no-exceptions
+// UNSUPPORTED: dylib-has-no-bad_variant_access && !libcpp-no-exceptions
 
 // <variant>
 
 // template <class ...Types> class variant;
 
 // variant(variant const&); // constexpr in C++20
 
 #include <cassert>

libcxx/test/std/utilities/variant/variant.variant/variant.ctor/default.pass.cpp

 // -*- C++ -*-
 //===----------------------------------------------------------------------===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 //
 //===----------------------------------------------------------------------===//
 
 // UNSUPPORTED: c++98, c++03, c++11, c++14
 
-// XFAIL: dylib-has-no-bad_variant_access && !libcpp-no-exceptions
+// UNSUPPORTED: dylib-has-no-bad_variant_access && !libcpp-no-exceptions
 
 // <variant>
 
 // template <class ...Types> class variant;
 
 // constexpr variant() noexcept(see below);
 
 #include <cassert>

libcxx/test/std/utilities/variant/variant.variant/variant.ctor/in_place_index_args.pass.cpp

 // -*- C++ -*-
 //===----------------------------------------------------------------------===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 //
 //===----------------------------------------------------------------------===//
 
 // UNSUPPORTED: c++98, c++03, c++11, c++14
 
-// XFAIL: dylib-has-no-bad_variant_access && !libcpp-no-exceptions
+// UNSUPPORTED: dylib-has-no-bad_variant_access && !libcpp-no-exceptions
 
 // <variant>
 
 // template <class ...Types> class variant;
 
 // template <size_t I, class ...Args>
 // constexpr explicit variant(in_place_index_t<I>, Args&&...);
 

libcxx/test/std/utilities/variant/variant.variant/variant.ctor/in_place_index_init_list_args.pass.cpp

 // -*- C++ -*-
 //===----------------------------------------------------------------------===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 //
 //===----------------------------------------------------------------------===//
 
 // UNSUPPORTED: c++98, c++03, c++11, c++14
-// XFAIL: dylib-has-no-bad_variant_access && !libcpp-no-exceptions
+// UNSUPPORTED: dylib-has-no-bad_variant_access && !libcpp-no-exceptions
 
 // <variant>
 
 // template <class ...Types> class variant;
 
 // template <size_t I, class Up, class ...Args>
 // constexpr explicit
 // variant(in_place_index_t<I>, initializer_list<Up>, Args&&...);

libcxx/test/std/utilities/variant/variant.variant/variant.ctor/in_place_type_args.pass.cpp

 // -*- C++ -*-
 //===----------------------------------------------------------------------===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 //
 //===----------------------------------------------------------------------===//
 
 // UNSUPPORTED: c++98, c++03, c++11, c++14
 
-// XFAIL: dylib-has-no-bad_variant_access && !libcpp-no-exceptions
+// UNSUPPORTED: dylib-has-no-bad_variant_access && !libcpp-no-exceptions
 
 // <variant>
 
 // template <class ...Types> class variant;
 
 // template <class Tp, class ...Args>
 // constexpr explicit variant(in_place_type_t<Tp>, Args&&...);
 

libcxx/test/std/utilities/variant/variant.variant/variant.ctor/in_place_type_init_list_args.pass.cpp

 // -*- C++ -*-
 //===----------------------------------------------------------------------===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 //
 //===----------------------------------------------------------------------===//
 
 // UNSUPPORTED: c++98, c++03, c++11, c++14
-// XFAIL: dylib-has-no-bad_variant_access && !libcpp-no-exceptions
+// UNSUPPORTED: dylib-has-no-bad_variant_access && !libcpp-no-exceptions
 
 // <variant>
 
 // template <class ...Types> class variant;
 
 // template <class Tp, class Up, class ...Args>
 // constexpr explicit
 // variant(in_place_type_t<Tp>, initializer_list<Up>, Args&&...);

libcxx/test/std/utilities/variant/variant.variant/variant.ctor/move.pass.cpp

 // -*- C++ -*-
 //===----------------------------------------------------------------------===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 //
 //===----------------------------------------------------------------------===//
 
 // UNSUPPORTED: c++98, c++03, c++11, c++14
 
-// XFAIL: dylib-has-no-bad_variant_access && !libcpp-no-exceptions
+// UNSUPPORTED: dylib-has-no-bad_variant_access && !libcpp-no-exceptions
 
 // <variant>
 
 // template <class ...Types> class variant;
 
 // variant(variant&&) noexcept(see below); // constexpr in C++20
 
 #include <cassert>

libcxx/test/std/utilities/variant/variant.variant/variant.mod/emplace_index_args.pass.cpp

 // -*- C++ -*-
 //===----------------------------------------------------------------------===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 //
 //===----------------------------------------------------------------------===//
 
 // UNSUPPORTED: c++98, c++03, c++11, c++14
 
-// XFAIL: dylib-has-no-bad_variant_access && !libcpp-no-exceptions
+// UNSUPPORTED: dylib-has-no-bad_variant_access && !libcpp-no-exceptions
 
 // <variant>
 
 // template <class ...Types> class variant;
 
 // template <size_t I, class ...Args>
 //   variant_alternative_t<I, variant<Types...>>& emplace(Args&&... args);
 

libcxx/test/std/utilities/variant/variant.variant/variant.mod/emplace_index_init_list_args.pass.cpp

 // -*- C++ -*-
 //===----------------------------------------------------------------------===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 //
 //===----------------------------------------------------------------------===//
 
 // UNSUPPORTED: c++98, c++03, c++11, c++14
 
-// XFAIL: dylib-has-no-bad_variant_access && !libcpp-no-exceptions
+// UNSUPPORTED: dylib-has-no-bad_variant_access && !libcpp-no-exceptions
 
 // <variant>
 
 // template <class ...Types> class variant;
 
 // template <size_t I, class U, class ...Args>
 //   variant_alternative_t<I, variant<Types...>>& emplace(initializer_list<U> il,Args&&... args);
 

libcxx/test/std/utilities/variant/variant.variant/variant.mod/emplace_type_args.pass.cpp

 // -*- C++ -*-
 //===----------------------------------------------------------------------===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 //
 //===----------------------------------------------------------------------===//
 
 // UNSUPPORTED: c++98, c++03, c++11, c++14
 
-// XFAIL: dylib-has-no-bad_variant_access && !libcpp-no-exceptions
+// UNSUPPORTED: dylib-has-no-bad_variant_access && !libcpp-no-exceptions
 
 // <variant>
 
 // template <class ...Types> class variant;
 
 // template <class T, class ...Args> T& emplace(Args&&... args);
 
 #include <cassert>

libcxx/test/std/utilities/variant/variant.variant/variant.mod/emplace_type_init_list_args.pass.cpp

 // -*- C++ -*-
 //===----------------------------------------------------------------------===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 //
 //===----------------------------------------------------------------------===//
 
 // UNSUPPORTED: c++98, c++03, c++11, c++14
 
-// XFAIL: dylib-has-no-bad_variant_access && !libcpp-no-exceptions
+// UNSUPPORTED: dylib-has-no-bad_variant_access && !libcpp-no-exceptions
 
 // <variant>
 
 // template <class ...Types> class variant;
 
 // template <class T, class U, class ...Args>
 //   T& emplace(initializer_list<U> il,Args&&... args);
 

libcxx/test/std/utilities/variant/variant.variant/variant.swap/swap.pass.cpp

 // -*- C++ -*-
 //===----------------------------------------------------------------------===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 //
 //===----------------------------------------------------------------------===//
 
 // UNSUPPORTED: c++98, c++03, c++11, c++14
 
-// XFAIL: dylib-has-no-bad_variant_access && !libcpp-no-exceptions
+// UNSUPPORTED: dylib-has-no-bad_variant_access && !libcpp-no-exceptions
 
 // <variant>
 
 // template <class ...Types> class variant;
 
 // void swap(variant& rhs) noexcept(see below)
 
 #include <cassert>

libcxx/test/std/utilities/variant/variant.visit/visit.pass.cpp

 // -*- C++ -*-
 //===----------------------------------------------------------------------===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 //
 //===----------------------------------------------------------------------===//
 
 // UNSUPPORTED: c++98, c++03, c++11, c++14
 
-// XFAIL: dylib-has-no-bad_variant_access && !libcpp-no-exceptions
+// UNSUPPORTED: dylib-has-no-bad_variant_access && !libcpp-no-exceptions
 
 // <variant>
 // template <class Visitor, class... Variants>
 // constexpr see below visit(Visitor&& vis, Variants&&... vars);
 
 #include <cassert>
 #include <memory>
 #include <string>